75225[BUGFIX] Respect non standard prototype names
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Daniel Gohlke +1
- Björn Jacob +1
-
Verified V +2 Done
- waldhacker +2
- Daniel Gohlke +1
- Björn Jacob +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1825
-
waldhacker commented on patch set 1 07/26/22, 10:42
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Classes/Core/FormRequestHandler.php -
waldhacker uploaded patch set 2 07/26/22, 10:45
-
waldhacker marked it ready for review 07/26/22, 10:46
-
core-ci voted on patch set 2 V +1 07/26/22, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29543
-
core-ci voted on patch set 1 V -1 07/26/22, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29542
-
Oliver Klee commented on patch set 2 07/26/22, 11:15
Ralf, I strongly recommend not creating the backport(s) as long as the main version of the change is not merged. (And usually, the merger takes care of the backport, not the change author, unless otherwise agreed on.) The reason for this workflow is that it avoids having to do the changes requested in the review comments in multiple changes in parallel, which is time-consuming and error-prone. -
Oliver Klee voted on patch set 2 CR -1 07/26/22, 11:15
-
waldhacker marked it work in progress 07/26/22, 11:21
-
waldhacker commented on patch set 2 07/26/22, 11:24
I have created it for testing purposes. -
waldhacker commented on patch set 3 07/26/22, 14:53
Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 07/26/22, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29549
-
waldhacker commented on patch set 4 07/29/22, 14:10
Published edit on patch set 3. -
waldhacker commented on patch set 5 07/29/22, 14:12
Published edit on patch set 4. -
core-ci voted on patch set 4 V -1 07/29/22, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29699
-
core-ci voted on patch set 5 V +1 07/29/22, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29702
-
waldhacker commented on patch set 6 07/29/22, 14:41
Published edit on patch set 5. -
core-ci voted on patch set 6 V +1 07/29/22, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29706
-
Oliver Klee wrote 07/29/22, 14:54
Removed reviewer Oliver Klee. -
waldhacker uploaded patch set 7 08/08/22, 13:07
-
waldhacker commented on patch set 7 08/08/22, 13:08
This change is ready for review. -
Daniel Gohlke voted on patch set 7 V +1 CR +1 08/08/22, 13:12
-
core-ci voted on patch set 7 V +1 08/08/22, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29955
-
Björn Jacob voted on patch set 7 V +1 CR +1 08/08/22, 13:16
-
waldhacker voted on patch set 7 V +2 CR +2 08/08/22, 13:17
-
waldhacker merged patch set 8 08/08/22, 13:17