75232[TASK] Avoid using TemplateService->rootLine
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+43 −10
- typo3/sysext/frontend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+20 −18
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+9 −9
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+5 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+53 −5
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+3 −3
- typo3/sysext/frontend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+1 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+7 −12
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+1 −2
Review log 912
-
Christian Kuhn uploaded patch set 1 07/17/22, 10:13
-
core-ci voted on patch set 1 V +1 07/17/22, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29311
-
Christian Kuhn uploaded patch set 2 07/17/22, 11:23
-
Christian Kuhn uploaded patch set 3 07/17/22, 11:26
-
core-ci voted on patch set 3 V +1 07/17/22, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29313
-
core-ci voted on patch set 2 V +1 07/17/22, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29312
-
Stefan Bürk voted on patch set 3 V +1 CR +1 07/18/22, 11:07
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 07/18/22, 13:14
-
Benni Mack voted on patch set 3 V +1 CR +1 07/18/22, 13:26
-
Nikita Hovratov commented on patch set 3 CR +1 07/18/22, 19:24
Nice, thanks for clearing this up! I also once stumbled upon the rootLine properties of tsfe and was not aware of the special sorting. -
Christian Kuhn voted on patch set 3 V +2 CR +2 07/18/22, 20:14
-
Christian Kuhn merged patch set 4 07/18/22, 20:14