Review main Merged

75234[BUGFIX] Use config.extTarget as fallback for HMENU external links

Sascha Egerer CR +2 V +2 Easy +1 −1 updated 07/18/22, 21:32

Commit message

If a page of type external link does not have a "target" defined
the fallback should be used. This behavior has been changed in
#96470 so the fallback is not
used anymore as an empty string is also respected as a valid value
but should not.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Sascha Egerer uploaded patch set 1 07/17/22, 21:12

  2. core-ci voted on patch set 1 V +1 07/17/22, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29319

  3. Anja Leichsenring updated the commit message in patch set 2 07/18/22, 13:16

  4. Anja Leichsenring voted on patch set 2 V +1 CR +1 07/18/22, 13:17

  5. core-ci voted on patch set 2 V +1 07/18/22, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29332

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 07/18/22, 21:32

  7. Stefan Bürk merged patch set 3 07/18/22, 21:32