Review main Merged

75239[DOCS] Distinguish composer and legacy installation in cron examples

Chris Müller CR +2 V +2 Normal +52 −25 updated 07/19/22, 07:08

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1216

  1. Chris Müller uploaded patch set 1 07/18/22, 14:28

  2. Chris Müller updated the commit message in patch set 2 07/18/22, 14:31

  3. Chris Müller updated the commit message in patch set 3 07/18/22, 14:32

  4. core-ci voted on patch set 1 V +1 07/18/22, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29335

  5. core-ci voted on patch set 2 V +1 07/18/22, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29336

  6. core-ci voted on patch set 3 V +1 07/18/22, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29337

  7. Nikita Hovratov commented on patch set 3 07/18/22, 19:07

    Index.rst:33

    The two dots were correct here as weird as it looked. One for etc and one for the sentence.
  8. Oliver Klee commented on patch set 3 07/18/22, 19:16

    Index.rst:33 Reply

    According to https://style.mla.org/abbreviation-period-end-sentence/ , there should only be one period.
  9. Oliver Klee commented on patch set 3 07/18/22, 19:16

    Index.rst:33 Reply

  10. Christian Kuhn commented on patch set 3 07/18/22, 23:00

    Index.rst:33 Reply

    Done
  11. Christian Kuhn updated the commit message in patch set 4 07/18/22, 23:03

  12. core-ci voted on patch set 4 V +1 07/18/22, 23:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29343

  13. Stefan Bürk voted on patch set 4 V +1 CR +1 07/18/22, 23:20

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 07/18/22, 23:25

  15. Christian Kuhn merged patch set 5 07/18/22, 23:25

  16. Nikita Hovratov commented on patch set 5 07/19/22, 07:08

    Index.rst:33 Reply

    Thanks for the sources Oliver!