Review main Merged

75248[BUGFIX] Resolve null coalesce order of operation issues

crell CR +2 V +2 Easy +2 −12 updated 07/22/22, 06:17

Commit message

The > operator binds higher than ??, meaning these are always comparing
null to 0.  That is clearly not the intent.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. crell uploaded patch set 1 07/20/22, 15:28

  2. core-ci voted on patch set 1 V +1 07/20/22, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29380

  3. Stefan Bürk updated the commit message in patch set 2 07/20/22, 20:48

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 07/20/22, 20:49

  5. core-ci voted on patch set 2 V +1 07/20/22, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29384

  6. Simon Schaufelberger voted on patch set 2 V +1 CR +1 07/21/22, 02:11

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 07/22/22, 06:17

  8. Stefan Bürk merged patch set 3 07/22/22, 06:17