Review main Merged

75255[BUGFIX] Avoid workspace PHP 8 error with relations

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 07/21/22, 12:22

Commit message

Relations in 'custom value' mode may not have translation
parents. This raises a PHP 8 array access issue in workspace
module when for instance a page translation defines own
relations for 'media': The workspace module main ajax call
crashes. Sanitize this.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 07/21/22, 12:10

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 07/21/22, 12:19

  3. core-ci voted on patch set 1 V +1 07/21/22, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29400

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 07/21/22, 12:21

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 07/21/22, 12:22

  6. Christian Kuhn merged patch set 2 07/21/22, 12:22