75257[TASK] Make code in ExtensionManagementUtility more concise
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Christian Kuhn +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1214
-
Nikita Hovratov uploaded patch set 1 07/21/22, 15:22
-
core-ci voted on patch set 1 V +1 07/21/22, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29405
-
Oliver Klee commented on patch set 1 07/21/22, 15:49
Is this about the possible cleanup or about a bugfix? If it is about a bugfix, I'd prefer us to describe the effect of the fix in the commit message subject line, not the way it is done. Or, in other words: Why are we doing this? (This is not clear from the commit message.) -
Nikita Hovratov commented on patch set 1 07/21/22, 16:32
Reply
This is a [TASK], I thought it's clear that this is only about regular housekeeping. Nothing interesting to describe, I think. -
Oliver Klee commented on patch set 1 07/21/22, 16:39
Reply
Ah, I see. Then I propose this commit message subject: [TASK] Make code in ExtensionManagementUtility more concise This better communicates the rationale, I think. -
Nikita Hovratov updated the commit message in patch set 2 07/21/22, 20:18
-
Nikita Hovratov commented on patch set 2 07/21/22, 20:18
Reply
Done -
core-ci voted on patch set 2 V +1 07/21/22, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29409
-
Oliver Klee voted on patch set 2 CR +1 07/21/22, 22:42
-
Andreas Kienast voted on patch set 2 V +1 CR +1 07/22/22, 09:31
-
Christian Kuhn voted on patch set 2 CR +1 07/22/22, 10:59
-
Benni Mack voted on patch set 2 V +1 CR +1 07/22/22, 11:35
-
Nikita Hovratov voted on patch set 2 V +2 CR +2 07/22/22, 11:38
-
Nikita Hovratov merged patch set 3 07/22/22, 11:38