Review main Merged

75258[BUGFIX] Avoid workspace PHP 8 crash when resorting relations

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 07/22/22, 16:41

Commit message

Scenario:
* Create a live page, add two images to media field
* Go to workspaces, edit page, resort the two images, save
* Go to workspace module of that page
-> Crash in main ajax call "DiffUtility::makeDiffDisplay():
Argument #1 ($str1) must be of type string, int given"

Fix with proper cast.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • crell +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 910

  1. Christian Kuhn uploaded patch set 1 07/22/22, 10:53

  2. Oliver Klee commented on patch set 1 07/22/22, 10:56

    RemoteServer.php:249

    To be really sure, be should string-cast the second argument as well.
  3. core-ci voted on patch set 1 V +1 07/22/22, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29420

  4. Christian Kuhn commented on patch set 1 07/22/22, 11:01

    RemoteServer.php:249 Reply

    no. it's done in the assignment above for all values already.
  5. Stefan Bürk voted on patch set 1 V +1 CR +1 07/22/22, 11:20

  6. Andreas Kienast voted on patch set 1 V +1 CR +1 07/22/22, 11:45

  7. Oliver Klee voted on patch set 1 CR +1 07/22/22, 11:46

  8. crell voted on patch set 1 CR +1 07/22/22, 16:27

  9. Stefan Bürk voted on patch set 1 V +2 CR +2 07/22/22, 16:41

  10. Stefan Bürk merged patch set 2 07/22/22, 16:41