Review main Merged

75260[BUGFIX] Ensure localized page preview url is build properly

Stefan Bürk CR +2 V +2 Easy +13 −4 updated 07/22/22, 20:12

Commit message

Localized page preview links in page layout module or view
module display page in default language.

With #97544 preview uri generation hooks has been replaced
with corresponding PSR-14 events. Language information has
been divided from the paramaters array to have it as direct
property in the new PSR-14 events.

`PageRouter->generateUri()` needs proper language information
as `$parameter` argument, which is not properly reassembled
before generating the preview uri in `PreviewUriBuilder()`,
using event information.

ext:workspace uses the before event to change the preview
uri only added the language id as query argument `_language`,
if additional query arguments are provided. This failing to
show localized workspaced page in workspace preview.

This change reassemble language information back into the
`$parameters` array to build localized preview uri again,
for live workspace preview and for workspace preview. This
is also done in corresponding ext:workspace eventlistener
to always provide non-default language query argument with
the newer `_language` parameter, even if there are no other
additional query arguments.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1014

  1. Stefan Bürk uploaded patch set 1 07/22/22, 13:09

  2. Stefan Bürk uploaded patch set 2 07/22/22, 13:14

  3. core-ci voted on patch set 1 V +1 07/22/22, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29427

  4. core-ci voted on patch set 2 V +1 07/22/22, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29428

  5. Simon Schaufelberger commented on patch set 2 07/22/22, 14:38

    This is a regression fix from your change https://review.typo3.org/c/Packages/TYPO3.CMS/+/74499 Could you have a look please?
  6. Stefan Bürk uploaded patch set 3 07/22/22, 15:49

  7. core-ci voted on patch set 3 V +1 07/22/22, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29429

  8. Simon Schaufelberger voted on patch set 3 V +1 CR +1 07/22/22, 17:34

  9. Stefan Bürk uploaded patch set 4 07/22/22, 19:45

  10. Christian Kuhn commented on patch set 4 V +1 CR +1 07/22/22, 19:48

    Reply

    Done
  11. core-ci voted on patch set 4 V +1 07/22/22, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29436

  12. Simon Schaufelberger voted on patch set 4 V +1 CR +1 07/22/22, 20:11

  13. Stefan Bürk voted on patch set 4 V +2 CR +2 07/22/22, 20:12

  14. Stefan Bürk merged patch set 5 07/22/22, 20:12