Review main Merged

75262[TASK] Remove unnecessary conditionals

crell CR +2 V +2 Normal +24 −47 updated 07/25/22, 20:35

Commit message

PHPStan says all of these are unnecessary. On visual
inspection, it appears to be correct.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 710

  1. crell uploaded patch set 1 07/22/22, 18:00

  2. core-ci voted on patch set 1 V +1 07/22/22, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29431

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 07/25/22, 17:58

  4. Stefan Bürk uploaded patch set 2 07/25/22, 19:37

  5. core-ci voted on patch set 2 V +1 07/25/22, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29509

  6. Stefan Bürk updated the commit message in patch set 3 07/25/22, 19:49

  7. Nikita Hovratov voted on patch set 3 V +1 CR +1 07/25/22, 19:52

  8. core-ci voted on patch set 3 V +1 07/25/22, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29510

  9. Stefan Bürk voted on patch set 3 V +2 CR +2 07/25/22, 20:08

  10. Stefan Bürk merged patch set 4 07/25/22, 20:35