Review main Merged

75267[BUGFIX] Use sanitized filename as source identifier when replacing an image

Simon Schaufelberger CR +2 V +2 Easy +1 −1 updated 08/05/22, 19:46

Commit message

Since the persisted file is stored with a sanitized filename, it must be
replaced with a sanitized file name as well, otherwise an error occurs
that the source with the un-sanitized file name could not be found.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Torben Hansen +1
    • Nikita Hovratov +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Riccardo De Contardi +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Simon Schaufelberger uploaded patch set 1 07/22/22, 20:38

  2. core-ci voted on patch set 1 V +1 07/22/22, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29439

  3. Oliver Hader voted on patch set 1 CR +1 07/23/22, 09:07

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 08/04/22, 09:45

  5. Riccardo De Contardi commented on patch set 1 V +1 08/04/22, 10:49

    Tested on latest master
  6. Torben Hansen voted on patch set 1 CR +1 08/04/22, 16:48

  7. Riccardo De Contardi commented on patch set 1 08/05/22, 18:43

    Verified on latest main
  8. Christian Kuhn voted on patch set 1 V +2 CR +2 08/05/22, 19:46

  9. Christian Kuhn merged patch set 2 08/05/22, 19:46