75268[TASK] Make DatabaseTreeDataProvider strictly typed
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2733
Show 68 earlier messages
-
crell uploaded patch set 1 07/22/22, 21:14
-
core-ci voted on patch set 1 V +1 07/22/22, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29440
-
Oliver Hader marked it work in progress 07/23/22, 08:59
-
Oliver Hader commented on patch set 1 07/23/22, 09:00
Please include properties as well if it "likely could be [done]" -
crell uploaded patch set 2 07/25/22, 15:24
-
crell marked it ready for review 07/25/22, 15:24
-
core-ci voted on patch set 2 V +1 07/25/22, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29503
-
Stefan Bürk commented on patch set 2 07/25/22, 19:47
DatabaseTreeDataProvider.php:205Should be `?DatabaseTreeNode`
-
crell uploaded patch set 3 07/25/22, 21:51
-
crell commented on patch set 3 07/25/22, 21:52
DatabaseTreeDataProvider.php:205ReplyAck -
Oliver Klee commented on patch set 3 07/25/22, 21:57
DatabaseTreeDataProvider.php:53/** * @var self::MODE_* */DatabaseTreeDataProvider.php:137@param self::MODE_* $lookupMode (We might need additional type annotations in the callers for this.)DatabaseTreeDataProvider.php:145@return self::MODE_* -
crell uploaded patch set 4 07/25/22, 22:36
-
crell commented on patch set 3 07/25/22, 22:36
DatabaseTreeDataProvider.php:53ReplyDoneDatabaseTreeDataProvider.php:137ReplyLocal testing says it's fine with just the changes here.DatabaseTreeDataProvider.php:145ReplyDone -
core-ci voted on patch set 3 V +1 07/25/22, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29523
-
core-ci voted on patch set 4 V +1 07/25/22, 23:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29527
-
Oliver Klee voted on patch set 4 CR +1 07/26/22, 09:29
-
crell uploaded patch set 5 07/27/22, 14:16
-
core-ci voted on patch set 5 V +1 07/27/22, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29618
-
Oliver Hader voted on patch set 5 CR +1 07/27/22, 14:55
-
Simon Schaufelberger voted on patch set 5 CR +1 07/29/22, 01:14
-
Georg Ringer commented on patch set 5 CR -1 07/29/22, 06:27
Breaking-97210-TypesAddedToMethodSignaturesOrClassProperties.rst:17IMO it should be - :php:`\TYPO3\CMS\Core\Tree\TableConfiguration\DatabaseTreeDataProvider` -
Simon Schaufelberger voted on patch set 5 CR -1 07/29/22, 09:19
-
Stefan Bürk commented on patch set 5 07/30/22, 22:19
Simon, can you please explain your -1 ? -
Stefan Bürk uploaded patch set 6 07/30/22, 22:21
-
Stefan Bürk commented on patch set 6 07/30/22, 22:22
Breaking-97210-TypesAddedToMethodSignaturesOrClassProperties.rst:17ReplyDone -
core-ci voted on patch set 6 V +1 07/30/22, 22:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29731
-
Simon Schaufelberger commented on patch set 6 07/30/22, 22:31
Reply
I just wanted to revert my +1 and confirm what Georg found. -
Simon Schaufelberger voted on patch set 6 CR +1 07/30/22, 22:32
-
Simon Schaufelberger commented on patch set 6 07/30/22, 22:33
Reply
Done -
Stefan Bürk voted on patch set 6 V +1 CR +1 07/30/22, 22:33
-
Oliver Klee voted on patch set 6 CR +1 07/31/22, 07:58
-
Christian Kuhn voted on patch set 6 V +2 CR +2 07/31/22, 11:08
-
Christian Kuhn merged patch set 7 07/31/22, 11:08