Review main Merged

75269[BUGFIX] Correct bad doc type in QueryObjectModelFactory

crell CR +2 V +2 Easy +2 −7 updated 07/26/22, 21:04

Commit message

The docblock for QueryObjectModelFactory::comparison() expects
a string, specifically one of the QueryObjectModelConstants.JCR_OPERATOR_*
constants.  However, that class seems to no longer exist,
and what it actually uses is an integer. (Passing a string through
would break in subsequent sub-calls.)

This corrects the type to the correct integer constants that
are actually used in practice, and uses a language type
to ensure it is used properly.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. crell uploaded patch set 1 07/22/22, 21:49

  2. core-ci voted on patch set 1 V +1 07/22/22, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29441

  3. Oliver Klee voted on patch set 1 CR +1 07/23/22, 09:00

  4. Stefan Bürk updated the commit message in patch set 2 07/25/22, 20:53

  5. core-ci voted on patch set 2 V +1 07/25/22, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29516

  6. Oliver Klee voted on patch set 2 CR +1 07/25/22, 21:30

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 07/26/22, 21:04

  8. Stefan Bürk voted on patch set 2 V +2 CR +2 07/26/22, 21:04

  9. Stefan Bürk merged patch set 3 07/26/22, 21:04