Review main Merged

75270[TASK] Remove superfluous cast in LiveSearch

crell CR +2 V +2 Easy +1 −6 updated 07/26/22, 21:14

Commit message

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1518

  1. crell uploaded patch set 1 07/22/22, 21:54

  2. core-ci voted on patch set 1 V +1 07/22/22, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29442

  3. Oliver Hader voted on patch set 1 CR +1 07/23/22, 08:53

  4. Oliver Hader updated the commit message in patch set 2 07/23/22, 08:53

  5. Oliver Hader voted on patch set 2 CR +1 07/23/22, 08:54

  6. Oliver Klee voted on patch set 2 CR +1 07/23/22, 09:01

  7. core-ci voted on patch set 2 V +1 07/23/22, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29446

  8. Guido Schmechel voted on patch set 2 CR +1 07/23/22, 13:21

  9. Stefan Bürk updated the commit message in patch set 3 07/25/22, 20:43

  10. Stefan Bürk commented on patch set 3 V +1 CR +1 07/25/22, 20:43

    * Missing phpstan command in commit message.
  11. Stefan Bürk wrote 07/25/22, 20:44

    Removed Verified+1 by Stefan Bürk
  12. Stefan Bürk commented on patch set 3 CR -1 07/25/22, 20:50

    Not sure - maybe the (int) cast was intentional to get read of superflous leading zeros ? However the last else (default) is than the same as the first if() block. So first and last block can be combined as it does the same thing, if removing the (int) typecast is really "safe" in respect of "changing behaviour is okay".
  13. core-ci voted on patch set 3 V +1 07/25/22, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29515

  14. Stefan Bürk commented on patch set 3 CR +1 07/25/22, 21:29

    Reply

    My bad ... change is okay.
  15. Oliver Klee voted on patch set 3 CR +1 07/25/22, 21:30

  16. Stefan Bürk voted on patch set 3 V +1 07/26/22, 21:13

  17. Christian Kuhn voted on patch set 3 V +2 CR +2 07/26/22, 21:14

  18. Christian Kuhn merged patch set 4 07/26/22, 21:14