Review 11.5 Merged

75272[BUGFIX] Correct workspace overlays in DataMapProcessor

Christian Kuhn CR +2 V +2 Easy +33 −11 updated 07/23/22, 13:11

Commit message

Scenario:
* Create a live page that has a 'media' resource
* Create a localization of that page
* Go to workspace
* Edit the localized page
* Save
* Save again
-> crash "Array to string conversion" in DataHandler
   isSubmittedValueEqualToStoredValue()

Investigating this, the issue is not in
isSubmittedValueEqualToStoredValue() itself, but
within DataMapProcessor, which fails to apply
a workspace overlay due to #92209: The default
WorkspaceRestriction is not sufficient in this case.

The patch changes DataMapProcessor to apply
workspace overlays in a different way for this
special case.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 07/23/22, 12:45

  2. core-ci voted on patch set 1 V +1 07/23/22, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29453

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 07/23/22, 13:11

  4. Christian Kuhn merged patch set 2 07/23/22, 13:11