75274[!!!][BUGFIX] Set password forgot hash based on user uid in ext:felogin
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-95132-SetPasswordForgotHashBasedOnUserUidInExtfelogin.rst2new+48 −0
- typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php+15 −10
- typo3/sysext/felogin/Classes/Domain/Repository/FrontendUserRepository.php+17 −35
- typo3/sysext/felogin/Classes/Service/RecoveryService.php3+9 −14
- typo3/sysext/felogin/Classes/Service/RecoveryServiceInterface.php6deleted+0 −27
- typo3/sysext/felogin/Tests/Functional/Domain/Repository/FrontendUserRepositoryTest.php+15 −54
- typo3/sysext/felogin/Tests/Functional/Fixtures/fe_users.csv+4 −4
- typo3/sysext/felogin/Tests/Unit/Service/RecoveryServiceTest.php6+22 −17
Review log 3143
Show 1318 earlier messages
-
Torben Hansen uploaded patch set 1 07/24/22, 13:20
-
core-ci voted on patch set 1 V +1 07/24/22, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29466
-
Oliver Hader commented on patch set 1 07/25/22, 13:44
-
Torben Hansen commented on patch set 1 07/25/22, 17:00
RecoveryServiceInterface.php:22ReplyThought about that situation too. At least no extension in TER implements the interface, but yes, users could have implemented the interface in custom, non public projects. IMO the current RecoveryService / sendRecoveryEmail function has too many dependencies and unexpected behavior, since the calculation of the hash and the update of the user record happens in sendRecoveryEmail. Would it be better to keep the Interface and change the function signature? -
Torben Hansen rebased onto patch set 2 07/26/22, 04:55
-
core-ci voted on patch set 2 V +1 07/26/22, 05:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29539
-
Torben Hansen uploaded patch set 3 08/01/22, 17:36
-
Torben Hansen commented on patch set 3 08/01/22, 17:36
RecoveryServiceInterface.php:22ReplyI now only changed the function signature and kept the interface. -
core-ci voted on patch set 3 V -1 08/01/22, 17:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29768
-
Torben Hansen uploaded patch set 4 08/01/22, 17:57
-
core-ci voted on patch set 4 V +1 08/01/22, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29769
-
Simon Schaufelberger commented on patch set 4 08/02/22, 07:59
Breaking-95132-SetPasswordForgotHashBasedOnUserUidInExtfelogin.rst:24signature. don't you use a spell checker in the browser or saw the typo in phpstorm? -
Torben Hansen uploaded patch set 5 08/02/22, 08:18
-
Torben Hansen commented on patch set 5 08/02/22, 08:19
Breaking-95132-SetPasswordForgotHashBasedOnUserUidInExtfelogin.rst:24ReplyMissed that one. Done. -
core-ci voted on patch set 5 V +1 08/02/22, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29773
-
Simon Schaufelberger commented on patch set 5 08/02/22, 10:54
RecoveryService.php:56since they don't add any useful information, they can be dropped.RecoveryServiceInterface.php:29since they don't add any useful information, they can be dropped.RecoveryServiceTest.php:63since they don't add any useful information, they can be dropped.RecoveryServiceTest.php:237since they don't add any useful information, they can be dropped. -
Torben Hansen commented on patch set 5 08/02/22, 16:22
RecoveryService.php:56ReplyI prefer to remove all superfluous parameter and return type annotations in ext:felogin at once in a different commit. I will take care of that task in a different issue.RecoveryServiceInterface.php:29ReplyI prefer to remove all superfluous parameter and return type annotations in ext:felogin at once in a different commit. I will take care of that task in a different issue.RecoveryServiceTest.php:63ReplyI prefer to remove all superfluous parameter and return type annotations in ext:felogin at once in a different commit. I will take care of that task in a different issue.RecoveryServiceTest.php:237ReplyI prefer to remove all superfluous parameter and return type annotations in ext:felogin at once in a different commit. I will take care of that task in a different issue. -
Simon Schaufelberger commented on patch set 5 08/05/22, 09:15
RecoveryService.php:56ReplyAckRecoveryServiceInterface.php:29ReplyAckRecoveryServiceTest.php:63ReplyAckRecoveryServiceTest.php:237ReplyAck
-
Chris Müller uploaded patch set 6 08/08/22, 17:35
-
core-ci voted on patch set 6 V +1 08/08/22, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29960
-
Torben Hansen uploaded patch set 7 08/17/22, 17:32
-
core-ci voted on patch set 7 V +1 08/17/22, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30247
-
Torben Hansen rebased onto patch set 8 08/28/22, 12:34
-
core-ci voted on patch set 8 V +1 08/28/22, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30504
-
Simon Schaufelberger wrote 08/28/22, 19:34
Removed cc Simon Schaufelberger. -
Torben Hansen rebased onto patch set 9 09/24/22, 11:08
-
core-ci voted on patch set 9 V +1 09/24/22, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31500
-
Oliver Hader voted on patch set 9 CR +1 09/26/22, 20:00
-
Simon Schaufelberger voted on patch set 9 CR +1 09/27/22, 23:52
-
Benni Mack commented on patch set 9 09/28/22, 11:49
really, let's drop the RecoveryServiceInterface, which we now change. The interface is really useless, as it does not provide any benefit as is currently (implemented in EXT:felogin, cannot be overridden on a per-site basis or similar, but only via DI which can be done with the implementation class as well). -
Torben Hansen uploaded patch set 10 09/28/22, 13:53
-
Torben Hansen rebased onto patch set 11 09/28/22, 13:54
-
Torben Hansen updated the commit message in patch set 12 09/28/22, 13:56
-
Torben Hansen commented on patch set 12 09/28/22, 13:56
Reply
Done -
Benni Mack voted on patch set 12 CR +1 09/28/22, 14:01
-
core-ci voted on patch set 11 V +1 09/28/22, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31660
-
core-ci voted on patch set 10 V +1 09/28/22, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31659
-
core-ci voted on patch set 12 V +1 09/28/22, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31661
-
Benni Mack voted on patch set 12 V +1 09/29/22, 23:13
-
Georg Ringer voted on patch set 12 V +1 CR +1 09/30/22, 05:37
-
Markus Klein voted on patch set 12 CR +1 09/30/22, 06:56
-
Benni Mack voted on patch set 12 V +2 CR +2 09/30/22, 08:02
-
Benni Mack merged patch set 13 09/30/22, 08:02
RecoveryServiceInterface.php:22