75280[!!!][FEATURE] Implement TypoScript function modifier event
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 13
- typo3/sysext/core/Classes/TypoScript/AST/Event/EvaluateModifierFunctionEvent.php3new+85 −0
- typo3/sysext/core/Classes/TypoScript/AST/AstBuilder.php+30 −35
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98016-RemovedTypoScriptFunctionHook.rstnew+49 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-98016-PSR-14EvaluateModifierFunctionEvent.rst4new+65 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_ast_function_event/Classes/EventListener/TyposcriptTestFunction.phpnew+30 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_ast_function_event/Configuration/Services.yamlnew+10 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_ast_function_event/Resources/Public/Icons/Extension.svgnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_ast_function_event/ext_emconf.phpnew+22 −0
- typo3/sysext/core/Tests/Functional/TypoScript/AST/AstBuilderTest.phpnew+72 −0
- typo3/sysext/core/Tests/Unit/Fixtures/EventDispatcher/NoopEventDispatcher.phpnew+28 −0
- typo3/sysext/core/Tests/Unit/TypoScript/AST/AstBuilderTest.php+28 −16
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+6 −0
- composer.json+2 −1
Review log 2233
Show 48 earlier messages
-
Christian Kuhn uploaded patch set 1 07/25/22, 05:37
-
Christian Kuhn updated the commit message in patch set 2 07/25/22, 05:37
-
core-ci voted on patch set 1 V +1 07/25/22, 05:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29481
-
core-ci voted on patch set 2 V +1 07/25/22, 06:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29482
-
Christian Kuhn uploaded patch set 3 07/25/22, 07:27
-
core-ci voted on patch set 3 V +1 07/25/22, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29483
-
Christian Kuhn updated the commit message in patch set 4 07/25/22, 09:07
-
core-ci voted on patch set 4 V +1 07/25/22, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29484
-
Benni Mack updated the commit message in patch set 5 07/25/22, 09:32
-
core-ci voted on patch set 5 V +1 07/25/22, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29487
-
Benni Mack voted on patch set 5 CR +1 07/25/22, 10:45
-
Oliver Hader commented on patch set 5 07/25/22, 13:37
-
Christian Kuhn commented on patch set 5 CR -1 07/25/22, 13:45
will reconsider naming function argument naming.EvaluateModifierFunctionEvent.php:54Replyyes. naming sucks at this point. using 'argument' phrasing would be more in-line with common understanding. i pick that from the old implementation and didn't bother to change it. i'll reconsider. -
Christian Kuhn uploaded patch set 6 07/30/22, 13:03
-
Christian Kuhn commented on patch set 6 07/30/22, 13:04
EvaluateModifierFunctionEvent.php:54ReplyDone -
core-ci voted on patch set 6 V +1 07/30/22, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29715
-
Christian Kuhn uploaded patch set 7 07/30/22, 13:10
-
core-ci voted on patch set 7 V +1 07/30/22, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29716
-
Stefan Bürk uploaded patch set 8 07/30/22, 15:43
-
core-ci voted on patch set 8 V +1 07/30/22, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29718
-
Stefan Bürk voted on patch set 8 V +1 CR +1 07/30/22, 16:09
-
Stefan Bürk uploaded patch set 9 07/30/22, 18:33
-
Stefan Bürk uploaded patch set 10 07/30/22, 18:35
-
core-ci voted on patch set 10 V +1 07/30/22, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29721
-
core-ci voted on patch set 9 V -1 07/30/22, 18:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29720
-
Stefan Bürk voted on patch set 10 V +1 CR +1 07/30/22, 18:55
-
Simon Schaufelberger commented on patch set 10 CR -1 07/30/22, 19:16
Feature-98016-PSR-14EvaluateModifierFunctionEvent.rst:26that can...Feature-98016-PSR-14EvaluateModifierFunctionEvent.rst:35needs -
Stefan Bürk uploaded patch set 11 07/30/22, 19:32
-
Stefan Bürk commented on patch set 11 V +1 CR +1 07/30/22, 19:33
Feature-98016-PSR-14EvaluateModifierFunctionEvent.rst:26ReplyDoneFeature-98016-PSR-14EvaluateModifierFunctionEvent.rst:35ReplyDone -
core-ci voted on patch set 11 V +1 07/30/22, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29722
-
Benni Mack voted on patch set 11 V +1 CR +1 07/31/22, 10:50
-
Christian Kuhn voted on patch set 11 V +2 CR +2 07/31/22, 11:00
-
Christian Kuhn merged patch set 12 07/31/22, 11:00
EvaluateModifierFunctionEvent.php:54