Review main Merged Breaking

75280[!!!][FEATURE] Implement TypoScript function modifier event

Christian Kuhn CR +2 V +2 Hard +428 −52 updated 07/31/22, 11:00

Commit message

The old TypoScript parser allows implementing own functions
for the := operator using a hook:

  someIdentifier := myCustomFunction(myFunctionArgument)

The new TypoScript parser does not implement this hook
and adds a new event instead.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 13

Review log 2233

Show 48 earlier messages
  1. Christian Kuhn uploaded patch set 1 07/25/22, 05:37

  2. Christian Kuhn updated the commit message in patch set 2 07/25/22, 05:37

  3. core-ci voted on patch set 1 V +1 07/25/22, 05:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29481

  4. core-ci voted on patch set 2 V +1 07/25/22, 06:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29482

  5. Christian Kuhn uploaded patch set 3 07/25/22, 07:27

  6. core-ci voted on patch set 3 V +1 07/25/22, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29483

  7. Christian Kuhn updated the commit message in patch set 4 07/25/22, 09:07

  8. core-ci voted on patch set 4 V +1 07/25/22, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29484

  1. Benni Mack updated the commit message in patch set 5 07/25/22, 09:32

  2. core-ci voted on patch set 5 V +1 07/25/22, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29487

  3. Benni Mack voted on patch set 5 CR +1 07/25/22, 10:45

  4. Oliver Hader commented on patch set 5 07/25/22, 13:37

    EvaluateModifierFunctionEvent.php:54

    Nitpick on naming: * $functionName -> $name * $functionValue -> $param or $arguments (as it as given as that with that modifier function) * $currentValue -> $originalValue * setNewValue() -> setValue()
  5. Christian Kuhn commented on patch set 5 CR -1 07/25/22, 13:45

    will reconsider naming function argument naming.

    EvaluateModifierFunctionEvent.php:54 Reply

    yes. naming sucks at this point. using 'argument' phrasing would be more in-line with common understanding. i pick that from the old implementation and didn't bother to change it. i'll reconsider.
  6. Christian Kuhn uploaded patch set 6 07/30/22, 13:03

  7. Christian Kuhn commented on patch set 6 07/30/22, 13:04

    EvaluateModifierFunctionEvent.php:54 Reply

    Done
  8. core-ci voted on patch set 6 V +1 07/30/22, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29715

  9. Christian Kuhn uploaded patch set 7 07/30/22, 13:10

  10. core-ci voted on patch set 7 V +1 07/30/22, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29716

  11. Stefan Bürk uploaded patch set 8 07/30/22, 15:43

  12. core-ci voted on patch set 8 V +1 07/30/22, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29718

  13. Stefan Bürk voted on patch set 8 V +1 CR +1 07/30/22, 16:09

  14. Stefan Bürk uploaded patch set 9 07/30/22, 18:33

  15. Stefan Bürk uploaded patch set 10 07/30/22, 18:35

  16. core-ci voted on patch set 10 V +1 07/30/22, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29721

  17. core-ci voted on patch set 9 V -1 07/30/22, 18:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29720

  18. Stefan Bürk voted on patch set 10 V +1 CR +1 07/30/22, 18:55

  19. Simon Schaufelberger commented on patch set 10 CR -1 07/30/22, 19:16

    Feature-98016-PSR-14EvaluateModifierFunctionEvent.rst:26

    that can...

    Feature-98016-PSR-14EvaluateModifierFunctionEvent.rst:35

    needs
  20. Stefan Bürk uploaded patch set 11 07/30/22, 19:32

  21. Stefan Bürk commented on patch set 11 V +1 CR +1 07/30/22, 19:33

    Feature-98016-PSR-14EvaluateModifierFunctionEvent.rst:26 Reply

    Done

    Feature-98016-PSR-14EvaluateModifierFunctionEvent.rst:35 Reply

    Done
  22. core-ci voted on patch set 11 V +1 07/30/22, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29722

  23. Benni Mack voted on patch set 11 V +1 CR +1 07/31/22, 10:50

  24. Christian Kuhn voted on patch set 11 V +2 CR +2 07/31/22, 11:00

  25. Christian Kuhn merged patch set 12 07/31/22, 11:00