Review main Merged

75281[TASK] Improve TCA description of sys_template record fields

Christian Kuhn CR +2 V +2 Easy +36 −8 updated 07/25/22, 10:54

Commit message

Some of the more advanced fields of sys_template records
are rather hard to understand without additional description.

The patch moves all more complex fields to an "Advanced Options"
tab and uses the TCA "description" feature to add some
explanations and hints if and when integrators should bother
with them in typical scenarios.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1217

  1. Christian Kuhn uploaded patch set 1 07/25/22, 09:10

  2. Christian Kuhn updated the commit message in patch set 2 07/25/22, 09:11

  3. core-ci voted on patch set 2 V +1 07/25/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29486

  4. Benni Mack voted on patch set 2 V +1 CR +1 07/25/22, 09:32

  5. Christian Kuhn updated the commit message in patch set 3 07/25/22, 10:05

  6. core-ci voted on patch set 3 V +1 07/25/22, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29488

  7. Nikita Hovratov uploaded patch set 4 07/25/22, 10:19

  8. core-ci voted on patch set 4 V +1 07/25/22, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29489

  9. Nikita Hovratov uploaded patch set 5 07/25/22, 10:29

  10. Nikita Hovratov updated the commit message in patch set 6 07/25/22, 10:31

  11. Nikita Hovratov voted on patch set 6 V +1 CR +1 07/25/22, 10:32

  12. core-ci voted on patch set 5 V +1 07/25/22, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29491

  13. core-ci voted on patch set 6 V +1 07/25/22, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29492

  14. Benni Mack commented on patch set 6 V +1 CR +1 07/25/22, 10:44

    I propose (not really a requirement) for the backport to keep the fields at their "old" location with the tabs, as people might have created screenshots etc. already for the latest LTS release.
  15. Christian Kuhn commented on patch set 6 07/25/22, 10:47

    Reply

    yeah. will do.
  16. Georg Ringer voted on patch set 6 V +2 CR +2 07/25/22, 10:53

  17. Georg Ringer merged patch set 7 07/25/22, 10:54