Review main Merged

75283[BUGFIX] DataHandler chokes with PHP 8 and ctrl fields

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 07/25/22, 13:21

Commit message

Not setting

$GLOBALS['TCA']['myTable']['ctrl']['crdate'] or
$GLOBALS['TCA']['myTable']['ctrl']['cruser_id'] or
$GLOBALS['TCA']['myTable']['ctrl']['tstamp']

leads to rather obvious PHP 8 "Undefined array key"
warnings in DataHandler. Sanitize them.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Christian Kuhn uploaded patch set 1 07/25/22, 12:34

  2. Christian Kuhn updated the commit message in patch set 2 07/25/22, 12:35

  3. core-ci voted on patch set 1 V +1 07/25/22, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29497

  4. core-ci voted on patch set 2 V +1 07/25/22, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29498

  5. Christian Kuhn commented on patch set 2 V +2 CR +2 07/25/22, 13:20

    merging as de-facto no-brainer.
  6. Christian Kuhn merged patch set 3 07/25/22, 13:21