Review 11.5 Merged

75284[BUGFIX] DataHandler chokes with PHP 8 and ctrl fields

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 07/25/22, 13:34

Commit message

Not setting

$GLOBALS['TCA']['myTable']['ctrl']['crdate'] or
$GLOBALS['TCA']['myTable']['ctrl']['cruser_id'] or
$GLOBALS['TCA']['myTable']['ctrl']['tstamp']

leads to rather obvious PHP 8 "Undefined array key"
warnings in DataHandler. Sanitize them.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 07/25/22, 13:22

  2. Oliver Hader voted on patch set 1 CR +1 07/25/22, 13:24

  3. core-ci voted on patch set 1 V +1 07/25/22, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29500

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 07/25/22, 13:34

  5. Christian Kuhn merged patch set 2 07/25/22, 13:34