75287[TASK] Ensure commit message contains needed commands
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
Review log 1624
-
Stefan Bürk uploaded patch set 1 07/25/22, 23:22
-
core-ci voted on patch set 1 V +1 07/25/22, 23:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29528
-
Stefan Bürk uploaded patch set 2 07/25/22, 23:33
-
core-ci voted on patch set 2 V +1 07/25/22, 23:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29529
-
Simon Schaufelberger commented on patch set 2 CR -1 07/26/22, 02:05
ancheckCommitMessageForCommands.sh:7typocheckCommitMessageForCommands.sh:8additionallycheckCommitMessageForCommands.sh:29there is no need for ./. can also be without. -
Stefan Bürk uploaded patch set 3 07/26/22, 03:44
-
Stefan Bürk commented on patch set 3 07/26/22, 03:44
Reply
DonecheckCommitMessageForCommands.sh:7ReplyDonecheckCommitMessageForCommands.sh:8ReplyDonecheckCommitMessageForCommands.sh:29ReplyDone -
Stefan Bürk updated the commit message in patch set 4 07/26/22, 03:45
-
Stefan Bürk uploaded patch set 5 07/26/22, 03:47
-
Stefan Bürk uploaded patch set 6 07/26/22, 03:48
-
Stefan Bürk commented on patch set 6 07/26/22, 03:51
Generic * PatchSet 3 pushed to incorporate comments from Simon Schaufelberger. Pushed two patchset which should explictly fail: * PatchSet 4: Used command in commit message without need * PatchSet 5: Missing mentioning used command in commit message PatchSet 6 was to revert / cleanup tests. -
core-ci voted on patch set 3 V +1 07/26/22, 03:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29533
-
Stefan Bürk uploaded patch set 7 07/26/22, 03:55
-
Stefan Bürk commented on patch set 7 07/26/22, 03:58
Reply
Correctly failed pre-merge jobs: * PatchSet 4: https://git.typo3.org/typo3/CI/cms/-/jobs/1452263 * PatchSet 5: https://git.typo3.org/typo3/CI/cms/-/jobs/1452314 -
core-ci voted on patch set 6 V -1 07/26/22, 03:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29536
-
core-ci voted on patch set 4 V -1 07/26/22, 04:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29534
-
Stefan Bürk uploaded patch set 8 07/26/22, 04:01
-
core-ci voted on patch set 7 V -1 07/26/22, 04:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29537
-
core-ci voted on patch set 5 V -1 07/26/22, 04:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29535
-
core-ci voted on patch set 8 V +1 07/26/22, 04:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29538
-
Christian Kuhn commented on patch set 8 07/26/22, 17:14
unsure if adding this as hard rule is really necessary. -
Oliver Klee commented on patch set 8 07/26/22, 17:37
checkCommitMessageForCommands.sh:29I propose we remove the "> " part from the check. Then my commit message in the past (which contain "> ./Build/…" wouldn't be flagged. :-) Or we could change the regexp to optionally also accept "> ./Build/…". (I'd also be okay with keeping it the way it is, but would prefer the check to allow the other valid format as well in order to reduce false positives.) -
Stefan Bürk commented on patch set 8 07/26/22, 17:55
Reply
Rethought this. Ack. At least we should postulate and communicate it as a hardrule with a "defined" sytax before adding a test.checkCommitMessageForCommands.sh:29ReplyRethought this. At least we should postulate and communicate it as a hardrule with a "defined" sytax before adding a test. Just for answering: Used "> " as a prefix to differenciate as "usages" to "name" it somehow instead, for a patch who is "changing" that command etc. If we do this, we should have a simply defined and prior communicated sytax, avoiding "a bunch of variations to support" to keep it simple. Anyway, will abandon this patch. -
Stefan Bürk abandoned the change 07/26/22, 17:58