Review 10.4 Merged

75294[TASK] Raise typo3/testing-framework

Christian Kuhn CR +2 V +2 Easy +25 −17 updated 07/26/22, 18:10

Commit message

Casual raise of v6 typo3/testing-framework.

> composer req --dev mikey179/vfsstream:^1.6.11
> composer req --dev typo3/testing-framework:^6.16.6

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1011

  1. Christian Kuhn uploaded patch set 1 07/26/22, 17:50

  2. core-ci voted on patch set 1 V +1 07/26/22, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29564

  3. Oliver Klee commented on patch set 1 CR +1 07/26/22, 17:56

    I‘m wondering what the difference between a casual and a non-casual raise would be …
    The corresponding commands for the composer.json for sysext/core is missing. (This is only for the sake of completeness as there will be no backports of this backport anyway.)
  4. Oliver Klee voted on patch set 1 V +1 07/26/22, 17:56

  5. Christian Kuhn commented on patch set 1 07/26/22, 17:57

    Reply

    yeah. did it manually in this case. hope that's fine.
  6. Stefan Bürk voted on patch set 1 V +1 CR +1 07/26/22, 17:58

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 07/26/22, 18:00

  8. Christian Kuhn merged patch set 2 07/26/22, 18:00

  9. Christian Kuhn commented on patch set 2 07/26/22, 18:00

    Reply

    Ack
  10. Christian Kuhn commented on patch set 2 07/26/22, 18:02

    Reply

    we don't raise v10 *that* often anymore. a relatively huge number of releases piled up by now, so we decided to raise it this time in v10 as well.
  11. Oliver Klee commented on patch set 2 07/26/22, 18:10

    Reply

    Yes, of course!