Review main Merged

75296[BUGFIX] Fix PHP 8.2 issue

Christian Kuhn CR +2 V +2 Easy +6 −22 updated 07/26/22, 18:57

Commit message

Prophecy has a minor PHP 8.2 issue as reported
with https://github.com/phpspec/prophecy/issues/555

This seems to be triggered by willBeConstructedWith()
when SuT has constructors in its inheritance chain.

Luckily, we can simplify the test a bit and
circumvent the issue for now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/26/22, 18:38

  2. Christian Kuhn uploaded patch set 2 07/26/22, 18:43

  3. core-ci voted on patch set 1 V +1 07/26/22, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29566

  4. core-ci voted on patch set 2 V +1 07/26/22, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29567

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 07/26/22, 18:55

  6. Christian Kuhn commented on patch set 2 07/26/22, 18:57

    will merge this now since it's "only" test related and we want to go ahead with php 8.2 right now.
  7. Christian Kuhn voted on patch set 2 V +2 CR +2 07/26/22, 18:57

  8. Christian Kuhn merged patch set 3 07/26/22, 18:57