Review 11.5 Merged

75303[BUGFIX] Correct bad doc type in QueryObjectModelFactory

Christian Kuhn CR +2 V +2 Easy +2 −7 updated 07/26/22, 21:04

Commit message

The docblock for QueryObjectModelFactory::comparison() expects
a string, specifically one of the QueryObjectModelConstants.JCR_OPERATOR_*
constants.  However, that class seems to no longer exist,
and what it actually uses is an integer. (Passing a string through
would break in subsequent sub-calls.)

This corrects the type to the correct integer constants that
are actually used in practice, and uses a language type
to ensure it is used properly.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Christian Kuhn uploaded patch set 1 07/26/22, 20:47

  2. core-ci voted on patch set 1 V +1 07/26/22, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29586

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 07/26/22, 21:02

  4. Stefan Bürk wrote 07/26/22, 21:03

    Removed Code-Review+2 by Stefan Bürk
  5. Stefan Bürk wrote 07/26/22, 21:03

    Removed Verified+2 by Stefan Bürk
  6. Stefan Bürk voted on patch set 1 V +2 CR +2 07/26/22, 21:04

  7. Stefan Bürk merged patch set 2 07/26/22, 21:04