Review 11.5 Merged

75304[TASK] Add tests for log `#[Channel(...)]` attribute

Stefan Bürk CR +2 V +2 Normal +230 −1 updated 07/26/22, 21:36

Commit message

v11 introduced support for using a Channel attribute to define
what log channel should be injected into a class, either via
the constructor or the LoggingAwareInterface. However, the
initial patch lacked any tests.

This patch adds basic tests to verify that the attribute works,
and indirectly document it.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 3

Files 7

Review log 59

  1. Stefan Bürk uploaded patch set 1 07/26/22, 20:57

  2. Stefan Bürk uploaded patch set 2 07/26/22, 21:02

  3. core-ci voted on patch set 1 V -1 07/26/22, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29588

  4. core-ci voted on patch set 1 V -1 07/26/22, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29588

  5. core-ci voted on patch set 2 V -1 07/26/22, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29590

  6. Stefan Bürk uploaded patch set 3 07/26/22, 21:24

  7. core-ci voted on patch set 3 V +1 07/26/22, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29597

  8. Stefan Bürk voted on patch set 3 V +2 CR +2 07/26/22, 21:36

  9. Stefan Bürk merged patch set 4 07/26/22, 21:36