Review main Merged Breaking

75306[!!!][TASK] Remove uses of the Serializable interface

crell CR +2 V +2 Normal +49 −76 updated 08/12/22, 19:40

Commit message

The Serializable interface has been deprecated, and is
slated for removal entirely in PHP 9. The preferred
serialization tool is the __serialize/__unserialize
method pair, which is already implemented and used
instead of Serializable. This patch removes the
already-deprecated and vestigial Serializable interface.

Serializable and __serialize() use a different string format,
so the fixture file needed to be updated as well.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2024

  1. crell uploaded patch set 1 07/26/22, 21:07

  2. crell commented on patch set 1 07/26/22, 21:10

    I'm unclear if this needs a new changelog file or an update to an existing one, since the use of Serializable was already deprecated. Please advise which and I'll update accordingly.
  3. core-ci voted on patch set 1 V +1 07/26/22, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29595

  4. Simon Schaufelberger commented on patch set 1 08/03/22, 23:32

    Reply

    Usually there is one deprecation and then finally a breaking when removed.
  5. Oliver Klee commented on patch set 1 08/09/22, 10:15

    Why should we remove uses of the interface?
  6. Oliver Klee commented on patch set 1 08/09/22, 10:16

    Ah, that's why: https://php.watch/versions/8.1/serializable-deprecated Could you please mention this rationale in the commit message?
  7. Oliver Klee commented on patch set 1 08/09/22, 10:17

    Ah, no, the interface itself is not deprecated, but only using it without also implementing the corresponding methods. We really should explain in the commit message why we're removing this.
  8. crell uploaded patch set 2 08/09/22, 16:14

  9. crell commented on patch set 1 08/09/22, 16:14

    Reply

    Done

    Reply

    Done
  10. core-ci voted on patch set 2 V +1 08/09/22, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29977

  11. Andreas Kienast commented on patch set 2 CR -1 08/10/22, 07:58

    This is a breaking change, so please provide documentation like for any other breaking change.
  12. crell uploaded patch set 3 08/10/22, 14:28

  13. core-ci voted on patch set 3 V +1 08/10/22, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30014

  14. crell commented on patch set 3 08/11/22, 00:11

    Reply

    Done
  15. Nikita Hovratov uploaded patch set 4 08/12/22, 19:29

  16. Anja Leichsenring voted on patch set 4 V +1 CR +1 08/12/22, 19:30

  17. Stefan Bürk voted on patch set 4 V +1 CR +1 08/12/22, 19:30

  18. Nikita Hovratov rebased onto patch set 5 08/12/22, 19:31

  19. Anja Leichsenring voted on patch set 5 V +1 CR +1 08/12/22, 19:32

  20. Christian Kuhn voted on patch set 5 V +1 CR +1 08/12/22, 19:33

  21. Nikita Hovratov voted on patch set 5 CR +1 08/12/22, 19:34

  22. core-ci voted on patch set 5 V +1 08/12/22, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30121

  23. Stefan Bürk voted on patch set 5 V +2 CR +2 08/12/22, 19:40

  24. Stefan Bürk merged patch set 6 08/12/22, 19:40