75306[!!!][TASK] Remove uses of the Serializable interface
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- Christian Kuhn +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Tree/TreeNode.php+1 −24
- typo3/sysext/backend/Classes/Tree/TreeNodeCollection.php+0 −25
- typo3/sysext/backend/Tests/Unit/Tree/Fixtures/serialized.txt+1 −1
- typo3/sysext/backend/Tests/Unit/Tree/TreeNodeTest.php+3 −4
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98032-SerializableInterfaceFullyRemoved.rstnew+44 −0
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php+0 −22
Review log 2024
-
crell uploaded patch set 1 07/26/22, 21:07
-
crell commented on patch set 1 07/26/22, 21:10
I'm unclear if this needs a new changelog file or an update to an existing one, since the use of Serializable was already deprecated. Please advise which and I'll update accordingly. -
core-ci voted on patch set 1 V +1 07/26/22, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29595
-
Simon Schaufelberger commented on patch set 1 08/03/22, 23:32
Reply
Usually there is one deprecation and then finally a breaking when removed. -
Oliver Klee commented on patch set 1 08/09/22, 10:15
Why should we remove uses of the interface? -
Oliver Klee commented on patch set 1 08/09/22, 10:16
Ah, that's why: https://php.watch/versions/8.1/serializable-deprecated Could you please mention this rationale in the commit message? -
Oliver Klee commented on patch set 1 08/09/22, 10:17
Ah, no, the interface itself is not deprecated, but only using it without also implementing the corresponding methods. We really should explain in the commit message why we're removing this. -
crell uploaded patch set 2 08/09/22, 16:14
-
core-ci voted on patch set 2 V +1 08/09/22, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29977
-
Andreas Kienast commented on patch set 2 CR -1 08/10/22, 07:58
This is a breaking change, so please provide documentation like for any other breaking change. -
crell uploaded patch set 3 08/10/22, 14:28
-
core-ci voted on patch set 3 V +1 08/10/22, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30014
-
crell commented on patch set 3 08/11/22, 00:11
Reply
Done -
Nikita Hovratov uploaded patch set 4 08/12/22, 19:29
-
Anja Leichsenring voted on patch set 4 V +1 CR +1 08/12/22, 19:30
-
Stefan Bürk voted on patch set 4 V +1 CR +1 08/12/22, 19:30
-
Nikita Hovratov rebased onto patch set 5 08/12/22, 19:31
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 08/12/22, 19:32
-
Christian Kuhn voted on patch set 5 V +1 CR +1 08/12/22, 19:33
-
Nikita Hovratov voted on patch set 5 CR +1 08/12/22, 19:34
-
core-ci voted on patch set 5 V +1 08/12/22, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30121
-
Stefan Bürk voted on patch set 5 V +2 CR +2 08/12/22, 19:40
-
Stefan Bürk merged patch set 6 08/12/22, 19:40