Review main Merged Breaking

75310[!!!][TASK] Resolve most #[ReturnTypeWillChange] attributes

crell CR +2 V +2 Hard +101 −242 updated 09/26/22, 14:56

Commit message

Sets return types for most classes that implement
PHP SPL classes. Only "mixed" return types are not
set: That would be hard breaking for extensions
that support both core v11 and v12, since it is not
PHP 7.4 compatible. Those places are marked with
an @todo to switch to mixed in v13.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 21

Show 1 more file

Review log 2227

Show 2 earlier messages
  1. crell uploaded patch set 1 07/26/22, 22:14

  2. crell uploaded patch set 2 07/26/22, 22:15

  1. core-ci voted on patch set 1 V -1 07/26/22, 22:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29600

  2. core-ci voted on patch set 2 V -1 07/26/22, 22:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29601

  3. crell uploaded patch set 3 07/27/22, 14:12

  4. core-ci voted on patch set 3 V +1 07/27/22, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29617

  5. Simon Schaufelberger voted on patch set 3 CR +1 07/29/22, 01:17

  6. crell uploaded patch set 4 08/05/22, 15:28

  7. core-ci voted on patch set 4 V +1 08/05/22, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29830

  8. Simon Schaufelberger voted on patch set 4 CR +1 08/16/22, 20:01

  9. Stefan Bürk voted on patch set 4 CR -1 08/17/22, 14:01

  10. Stefan Bürk commented on patch set 4 08/17/22, 14:06

    temp -1 - needs deeper view on this
  11. Stefan Bürk voted on patch set 4 CR 0 08/24/22, 21:23

  12. Stefan Bürk commented on patch set 4 08/24/22, 21:39

    To be honest - at to give some feedback. I had examined this patch multiple times now until this day. And even if my opionion shifted more to "yeah could be +1", there is still some kind of bad feeling which hinders me on that. But cannot really express it. Doing this is not only breaking, but people do not have the ability to make code to support v11 and v12 (basicly). I think that topic is basicly already known. I thought long about these questions: * Are there (real) use cases to extend the one or other class to enrich it with functionality ? * If yes, and the class is not marked as @internal - should the change than be shifted to TYPO3 v13 (then a v12/v13 compatible could would be possible * If yes, and the class not marked as @internal, but excluded as "core api" - but as extbase - may it be taken as kind of "public extbase" api ? As already mentioned, I'm more on the "okay let's do it" side - but cannot get rid of a feeling that it might be an oversight. This not voting yet.
  13. Simon Schaufelberger wrote 08/24/22, 22:09

    Removed reviewer Simon Schaufelberger with the following votes: * Code-Review+1 by Simon Schaufelberger
  14. Simon Schaufelberger voted on patch set 4 V +1 CR +1 09/24/22, 23:00

  15. Simon Schaufelberger commented on patch set 4 09/24/22, 23:03

    Reply

    let's do this. I don't think anyone would overwrite these methods and if someone really does, then he should release a different version for v12.
  16. Georg Ringer voted on patch set 4 V +1 CR +1 09/25/22, 13:57

  17. Christian Kuhn commented on patch set 4 CR -1 09/26/22, 10:51

    temp -1: i'll try to establish an opinion on this as well now.
  18. Christian Kuhn commented on patch set 4 09/26/22, 11:56

    i'll push on this.
  19. Christian Kuhn uploaded patch set 5 09/26/22, 14:40

  20. Christian Kuhn commented on patch set 5 09/26/22, 14:40

    Reply

    Done
  21. core-ci voted on patch set 5 V +1 09/26/22, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31540

  22. Stefan Bürk commented on patch set 5 V +1 CR +1 09/26/22, 14:56

    Reply

    Thanks for taking care @lolli.
  23. Christian Kuhn voted on patch set 5 V +1 CR +1 09/26/22, 14:56

  24. Stefan Bürk voted on patch set 5 V +2 CR +2 09/26/22, 14:56

  25. Stefan Bürk merged patch set 6 09/26/22, 14:56