75310[!!!][TASK] Resolve most #[ReturnTypeWillChange] attributes
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 21
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/adminpanel/Classes/ModuleApi/ModuleDataStorageCollection.php+1 −4
- typo3/sysext/backend/Classes/Controller/MfaAjaxController.php+8 −6
- typo3/sysext/backend/Classes/Tree/SortedTreeNodeCollection.php+5 −7
- typo3/sysext/backend/Classes/Tree/TreeNodeCollection.php+4 −10
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php+7 −27
- typo3/sysext/core/Classes/Log/LogRecord.php+6 −7
- typo3/sysext/core/Classes/Messaging/FlashMessageQueue.php+2 −6
- typo3/sysext/core/Classes/Resource/Collection/AbstractFileCollection.php+1 −0
- typo3/sysext/core/Classes/Resource/Search/Result/EmptyFileSearchResult.php+2 −18
- typo3/sysext/core/Classes/Resource/MetaDataAspect.php+2 −2
- typo3/sysext/core/Classes/Routing/SiteRouteResult.php+4 −11
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97210-TypesAddedToMethodSignaturesOrClassProperties.rst+15 −0
- typo3/sysext/core/Tests/Unit/Messaging/FlashMessageQueueTest.phpdeleted+0 −38
- typo3/sysext/extbase/Classes/Mvc/Controller/Arguments.php+9 −29
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyLoadingProxy.php+5 −13
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/QueryResult.php+10 −33
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php+10 −20
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+4 −2
Show 1 more file
Review log 2227
Show 2 earlier messages
-
core-ci voted on patch set 1 V -1 07/26/22, 22:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29600
-
core-ci voted on patch set 2 V -1 07/26/22, 22:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29601
-
crell uploaded patch set 3 07/27/22, 14:12
-
core-ci voted on patch set 3 V +1 07/27/22, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29617
-
Simon Schaufelberger voted on patch set 3 CR +1 07/29/22, 01:17
-
crell uploaded patch set 4 08/05/22, 15:28
-
core-ci voted on patch set 4 V +1 08/05/22, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29830
-
Simon Schaufelberger voted on patch set 4 CR +1 08/16/22, 20:01
-
Stefan Bürk voted on patch set 4 CR -1 08/17/22, 14:01
-
Stefan Bürk commented on patch set 4 08/17/22, 14:06
temp -1 - needs deeper view on this -
Stefan Bürk voted on patch set 4 CR 0 08/24/22, 21:23
-
Stefan Bürk commented on patch set 4 08/24/22, 21:39
To be honest - at to give some feedback. I had examined this patch multiple times now until this day. And even if my opionion shifted more to "yeah could be +1", there is still some kind of bad feeling which hinders me on that. But cannot really express it. Doing this is not only breaking, but people do not have the ability to make code to support v11 and v12 (basicly). I think that topic is basicly already known. I thought long about these questions: * Are there (real) use cases to extend the one or other class to enrich it with functionality ? * If yes, and the class is not marked as @internal - should the change than be shifted to TYPO3 v13 (then a v12/v13 compatible could would be possible * If yes, and the class not marked as @internal, but excluded as "core api" - but as extbase - may it be taken as kind of "public extbase" api ? As already mentioned, I'm more on the "okay let's do it" side - but cannot get rid of a feeling that it might be an oversight. This not voting yet. -
Simon Schaufelberger wrote 08/24/22, 22:09
Removed reviewer Simon Schaufelberger with the following votes: * Code-Review+1 by Simon Schaufelberger -
Simon Schaufelberger voted on patch set 4 V +1 CR +1 09/24/22, 23:00
-
Simon Schaufelberger commented on patch set 4 09/24/22, 23:03
Reply
let's do this. I don't think anyone would overwrite these methods and if someone really does, then he should release a different version for v12. -
Georg Ringer voted on patch set 4 V +1 CR +1 09/25/22, 13:57
-
Christian Kuhn commented on patch set 4 CR -1 09/26/22, 10:51
temp -1: i'll try to establish an opinion on this as well now. -
Christian Kuhn commented on patch set 4 09/26/22, 11:56
i'll push on this. -
Christian Kuhn uploaded patch set 5 09/26/22, 14:40
-
Christian Kuhn commented on patch set 5 09/26/22, 14:40
Reply
Done -
core-ci voted on patch set 5 V +1 09/26/22, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31540
-
Stefan Bürk commented on patch set 5 V +1 CR +1 09/26/22, 14:56
Reply
Thanks for taking care @lolli. -
Christian Kuhn voted on patch set 5 V +1 CR +1 09/26/22, 14:56
-
Stefan Bürk voted on patch set 5 V +2 CR +2 09/26/22, 14:56
-
Stefan Bürk merged patch set 6 09/26/22, 14:56