75315[BUGFIX] indexed_search: PHP 8 array key exists check
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1114
-
Daniel Hettler uploaded patch set 1 07/27/22, 15:12
-
core-ci voted on patch set 1 V +1 07/27/22, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29623
-
Oliver Klee voted on patch set 1 CR +1 07/27/22, 16:23
-
Christian Kuhn commented on patch set 1 07/27/22, 16:24
this would be shorter and a bit more elegant using ?? operator. -
Christian Kuhn uploaded patch set 2 07/27/22, 16:27
-
Christian Kuhn commented on patch set 2 V +1 CR +1 07/27/22, 16:27
I think this variant is a bit more concise. What do you think? -
Christian Kuhn updated the commit message in patch set 3 07/27/22, 16:28
-
Christian Kuhn voted on patch set 3 V +1 CR +1 07/27/22, 16:29
-
Oliver Klee voted on patch set 3 CR +1 07/27/22, 16:33
-
core-ci voted on patch set 3 V +1 07/27/22, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29626
-
core-ci voted on patch set 2 V +1 07/27/22, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29625
-
Nikita Hovratov voted on patch set 3 V +1 CR +1 07/27/22, 19:03
-
Christian Kuhn voted on patch set 3 V +2 CR +2 07/28/22, 12:51
-
Christian Kuhn merged patch set 4 07/28/22, 12:52