75316[BUGFIX] missing option controls on youtube video with PHP8.0 .
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 57
-
TYPO3com uploaded patch set 1 07/28/22, 10:24
-
core-ci voted on patch set 1 V -1 07/28/22, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29630
-
Guido Schmechel commented on patch set 1 CR -1 07/28/22, 14:47
-
Guido Schmechel commented on patch set 1 07/28/22, 17:18
We'll take a look at it together in the office next week. -
Stefan Bürk commented on patch set 1 07/29/22, 22:41
Reply Unresolved
Thanks Guido for picking this up, leave it for you then. And please, change to a proper commit message then - would be nice ;) -
Christian Kuhn commented on patch set 1 CR -1 08/12/22, 21:37
Thanks for the patch, but this looks fishy: * the warning shown in the screenshot for accessing the 'controls' key has never been on line 155. this smells as if some composer patch or other manual work has been added to the class locally. * method collectOptions() always sets the 'controls' key in $options. there shouldn't be a way to trigger the protected createYouTubeUrl() without this key being set under normal conditions. As such, we'll abandon the patch for now. Feel free to open a fresh issue or patch in case we missed something. -
Christian Kuhn abandoned the change 08/12/22, 21:37
Unresolved