Review main Abandoned

75316[BUGFIX] missing option controls on youtube video with PHP8.0 .

TYPO3com CR 0 V 0 Easy +3 −1 updated 08/12/22, 21:37

Commit message

Hello,

after creating a Text & Media Element and adding a *.youtube file to the
assets if was getting this error:

![image](https://user-images.githubusercontent.com/10448557/181482553-db4d
1041-f027-49bc-9b41-a32dbb43407e.png)

With this small fix the exception doesnt appear anymore.

System:
TYPO3: 11.5.13
PHP: 8.0.16

DDEV Config for reproduce purpose:
```
name: test-headless
type: typo3
docroot: public
php_version: "8.0"
composer_version: "2"
nodejs_version: "16"
database:
  type: mysql
  version: "5.7"
webserver_type: apache-fpm
router_http_port: "80"
router_https_port: "443"
xdebug_enabled: true
additional_fqdns: [ ]
nfs_mount_enabled: true
mutagen_enabled: false
webimage_extra_packages: [ cron ]
use_dns_when_possible: true
timezone: Europe/Berlin
web_environment: [ ]
```

Best regards
Fabio

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 57

  1. TYPO3com uploaded patch set 1 07/28/22, 10:24

  2. core-ci voted on patch set 1 V -1 07/28/22, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29630

  3. Guido Schmechel commented on patch set 1 CR -1 07/28/22, 14:47

    Unresolved

    https://developers.google.com/youtube/player_parameters?hl=de#controls Optimize query and check for 0,1 or 2. Default case is 0. Then the tests work again.
  4. Guido Schmechel commented on patch set 1 07/28/22, 17:18

    We'll take a look at it together in the office next week.
  5. Stefan Bürk commented on patch set 1 07/29/22, 22:41

    Reply Unresolved

    Thanks Guido for picking this up, leave it for you then. And please, change to a proper commit message then - would be nice ;)
  6. Christian Kuhn commented on patch set 1 CR -1 08/12/22, 21:37

    Thanks for the patch, but this looks fishy: * the warning shown in the screenshot for accessing the 'controls' key has never been on line 155. this smells as if some composer patch or other manual work has been added to the class locally. * method collectOptions() always sets the 'controls' key in $options. there shouldn't be a way to trigger the protected createYouTubeUrl() without this key being set under normal conditions. As such, we'll abandon the patch for now. Feel free to open a fresh issue or patch in case we missed something.
  7. Christian Kuhn abandoned the change 08/12/22, 21:37