Review main Merged

75317[TASK] Upgrade to codeception/codeception 5.x

Stefan Bürk CR +2 V +2 Hard +300 −199 updated 07/31/22, 10:58

Commit message

Codeception released new major version 5, which
unblocks upgrading to symfony 6 components.
This patch raises codeception only, thus acting as a
pre-patch to raise symfony requirements.

Codeception 5 is hard to impossible with core v11,
so this patch is v12 only: Codeception 5 requires
PHP 8.0, so we'd have to support both 4 and 5 in
v11 to allow testing with older PHP versions. This
would result in various headaches since some API
changes in codeception 5 are hard breaking in PHP,
especially due to changed class property type hints.
We'll thus keep codeception 4 in v11 and go with
codeception 5 in v12.

Minor acceptance test related adaptions are needed:

* Replaced config option `path.log` with `path.output`
* Added proper property type because of inheritance to
  codeception setup classes
* Ensure method return type compatibility
* Use `actor`instead of `class name` in suite config
* Create acceptance split files in proper folder to
  ensure group filtering keeps working. Adjust clean
  up scripts and gitignore for this

Used commands:

> composer req --dev -w \
  typo3/testing-framework:dev-main \
  codeception/codeception:^5.0.0 \
  codeception/module-asserts:^3.0.0 \
  codeception/module-cli:^2.0.0 \
  codeception/module-filesystem:^3.0.0 \
  codeception/module-webdriver:^3.1.2 \
  codeception/lib-asserts:^2.0.0

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 2336

Show 611 earlier messages
  1. Stefan Bürk uploaded patch set 1 07/28/22, 11:02

  2. core-ci voted on patch set 1 V -1 07/28/22, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29632

  3. Stefan Bürk uploaded patch set 2 07/28/22, 11:22

  4. core-ci voted on patch set 2 V -1 07/28/22, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29635

  5. Stefan Bürk uploaded patch set 3 07/28/22, 11:36

  6. core-ci voted on patch set 3 V -1 07/28/22, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29636

  7. Stefan Bürk uploaded patch set 4 07/28/22, 12:31

  8. core-ci voted on patch set 4 V +1 07/28/22, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29646

  9. Stefan Bürk commented on patch set 4 CR -1 07/28/22, 12:44

    Splitted Acceptance Testss do not executes any tests, but returning green instead.
  10. Stefan Bürk uploaded patch set 5 07/28/22, 13:24

  11. core-ci voted on patch set 5 V -1 07/28/22, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29649

  1. Stefan Bürk uploaded patch set 6 07/28/22, 13:33

  2. core-ci voted on patch set 6 V +1 07/28/22, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29650

  3. Oliver Klee commented on patch set 6 V +1 07/28/22, 13:57

    .gitignore:46

    While we're touching this line anyway: Shouldn't there also be a leading slash (for consistency)?
  4. Stefan Bürk commented on patch set 6 07/28/22, 13:58

    .gitignore:46 Reply

    ack ... will change this with the next push then.
  5. core-ci voted on patch set 6 V -1 07/28/22, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29651

  6. Stefan Bürk uploaded patch set 7 07/28/22, 14:34

  7. Stefan Bürk commented on patch set 6 07/28/22, 14:38

  8. Stefan Bürk commented on patch set 7 07/28/22, 14:39

    .gitignore:46 Reply

    Done
  9. core-ci voted on patch set 7 V +1 07/28/22, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29660

  10. Stefan Bürk updated the commit message in patch set 8 07/28/22, 15:25

  11. core-ci voted on patch set 8 V +1 07/28/22, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29662

  12. Stefan Bürk uploaded patch set 9 07/28/22, 17:13

  13. core-ci voted on patch set 9 V +1 07/28/22, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29665

  14. Christian Kuhn uploaded patch set 10 07/31/22, 10:13

  15. Christian Kuhn commented on patch set 10 07/31/22, 10:14

    Reply

    Done
  16. Christian Kuhn updated the commit message in patch set 11 07/31/22, 10:20

  17. Christian Kuhn updated the commit message in patch set 12 07/31/22, 10:21

  18. core-ci voted on patch set 12 V +1 07/31/22, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29748

  19. core-ci voted on patch set 10 V -1 07/31/22, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29746

  20. Oliver Klee voted on patch set 12 V +1 07/31/22, 10:48

  21. core-ci voted on patch set 10 V +1 07/31/22, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29746

  22. Christian Kuhn voted on patch set 12 V +1 CR +1 07/31/22, 10:58

  23. Stefan Bürk voted on patch set 12 V +1 CR +1 07/31/22, 10:58

  24. Stefan Bürk commented on patch set 12 V +2 CR +2 07/31/22, 10:58

    We need this merged because testing-framework is already prepared. Otherwise this will hardfail nightly.
  25. Stefan Bürk merged patch set 13 07/31/22, 10:58