Review main Merged

75318[BUGFIX] Avoid accessing null-row

Ingo Fabbri CR +2 V +2 Easy +8 −8 updated 11/17/22, 18:13

Commit message

With `fallbackType` set to strict, only translated content is rendered.

In AbstractMenuContentObject->sectionIndex content is fetched and
overlayed. Once there is an element untranslated, the record overlay
will return a $row = `null`.

To mitigate, move all left over access to $row inside
the guarded if-block.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2632

Show 57 earlier messages
  1. Ingo Fabbri uploaded patch set 1 07/28/22, 11:15

  2. Ingo Fabbri updated the commit message in patch set 2 07/28/22, 11:19

  3. core-ci voted on patch set 1 V +1 07/28/22, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29633

  4. core-ci voted on patch set 2 V +1 07/28/22, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29634

  5. Oliver Klee voted on patch set 2 CR +1 07/28/22, 12:30

  6. Simon Schaufelberger voted on patch set 2 CR +1 07/28/22, 20:35

  7. Nikita Hovratov commented on patch set 2 07/28/22, 20:43

    please start the commit message with capital case.
  1. Oliver Klee updated the commit message in patch set 3 07/28/22, 21:08

  2. Oliver Klee commented on patch set 3 CR +1 07/28/22, 21:09

    Reply

    Done
  3. core-ci voted on patch set 3 V +1 07/28/22, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29672

  4. Chris Müller voted on patch set 3 CR +1 07/31/22, 17:16

  5. Ingo Fabbri uploaded patch set 4 08/10/22, 11:33

  6. core-ci voted on patch set 4 V +1 08/10/22, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30005

  7. Oliver Klee wrote 08/10/22, 12:16

    Removed reviewer Oliver Klee.
  8. Oliver Klee commented on patch set 4 CR -1 08/10/22, 12:17

    Ingo, I think you have reverted my change in the commit message. Could you please undo that? Thanks!
  9. Ingo Fabbri commented on patch set 4 08/10/22, 12:26

    Reply

    I don't know how to do that. I just pushed another patch. Apparently it has overriden the commit of this patch too and added another patchset. How can I avoid that in the future?
  10. Ingo Fabbri uploaded patch set 5 08/10/22, 12:34

  11. Ingo Fabbri commented on patch set 5 CR +1 08/10/22, 12:35

    Reply

    Done
  12. Simon Schaufelberger commented on patch set 5 08/10/22, 12:39

    Reply

    you throw away your local changes and download the latest patch set again. so easy.
  13. core-ci voted on patch set 5 V +1 08/10/22, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30008

  14. Ingo Fabbri commented on patch set 5 08/10/22, 13:03

    Reply

    Usually I work in branches. But IIRC it is advised to work on main-branch and push from there. I did not question that and nowhere in the gerrit-typo3-forge-and-so-on-documention I could find a hint about that. So I will now do a git reset --hard origin/main whenever I am in the need to submit a core patch. Thanks!
  15. Simon Schaufelberger commented on patch set 5 08/10/22, 13:04

    Reply

    I'm also working with branches which I very much prefer over the main branch. To update a branch, use the Download -> reset to link.
  16. Simon Schaufelberger commented on patch set 5 08/10/22, 13:05

    Reply

    or delete the branch and check it out again.
  17. Ingo Fabbri commented on patch set 5 08/10/22, 13:09

    Reply

    Nice! Good to know.
  18. Oliver Klee wrote 08/10/22, 17:34

    Removed reviewer Oliver Klee.
  19. Oliver Klee voted on patch set 5 CR +1 08/10/22, 18:03

  20. Simon Schaufelberger wrote 08/10/22, 20:59

    Removed reviewer Simon Schaufelberger.
  21. Anja Leichsenring rebased onto patch set 6 11/17/22, 17:42

  22. core-ci voted on patch set 6 V +1 11/17/22, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33883

  23. Anja Leichsenring voted on patch set 6 V +1 CR +1 11/17/22, 18:07

  24. Christian Kuhn voted on patch set 6 V +2 CR +2 11/17/22, 18:13

  25. Christian Kuhn merged patch set 7 11/17/22, 18:13