75319[BUGFIX] Correct tree.pagelayout condition evaluation
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 5
- typo3/sysext/backend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php+6 −1
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php+6 −0
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+2 −2
- typo3/sysext/frontend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php+21 −3
- typo3/sysext/frontend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+64 −0
Review log 1723
-
Nikita Hovratov uploaded patch set 1 07/28/22, 11:54
-
core-ci voted on patch set 1 V +1 07/28/22, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29637
-
Nikita Hovratov uploaded patch set 2 07/28/22, 12:15
-
core-ci voted on patch set 2 V +1 07/28/22, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29640
-
Nikita Hovratov uploaded patch set 3 07/28/22, 20:13
-
core-ci voted on patch set 3 V +1 07/28/22, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29671
-
Simon Schaufelberger voted on patch set 3 V +1 CR +1 07/28/22, 20:29
-
Christian Kuhn commented on patch set 3 CR -1 08/02/22, 14:55
has another issue, we'll probably have a pre-patch. -
Christian Kuhn commented on patch set 3 08/14/22, 06:41
on it. -
Christian Kuhn uploaded patch set 4 08/14/22, 10:49
-
core-ci voted on patch set 4 V +1 08/14/22, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30165
-
Christian Kuhn voted on patch set 4 V +1 CR +1 08/14/22, 10:58
-
Christian Kuhn updated the commit message in patch set 5 08/14/22, 11:03
-
Christian Kuhn voted on patch set 5 V +1 CR +1 08/14/22, 11:04
-
core-ci voted on patch set 5 V +1 08/14/22, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30166
-
Stefan Bürk voted on patch set 5 V +1 CR +1 08/14/22, 14:37
-
Nikita Hovratov uploaded patch set 6 08/14/22, 19:37
-
core-ci voted on patch set 6 V +1 08/14/22, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30172
-
Stefan Bürk voted on patch set 6 V +1 CR +1 08/14/22, 19:44
-
Nikita Hovratov voted on patch set 6 V +1 CR +1 08/14/22, 19:47
-
Christian Kuhn voted on patch set 6 V +1 CR +1 08/14/22, 21:33
-
Nikita Hovratov voted on patch set 6 V +2 CR +2 08/15/22, 07:12
-
Nikita Hovratov merged patch set 7 08/15/22, 07:12