Review main Merged

75324[TASK] Remove 'exclude' from HIDE_FOR_NON_ADMINS fields

Christian Kuhn CR +2 V +2 Easy +0 −4 updated 07/31/22, 11:05

Commit message

TCA fields having displayCond='HIDE_FOR_NON_ADMINS'
can not be selected as "exclude" fields in user group
setup access rights setup.

It does not make sense to mark those exclude=true,
the patch removes that from affected fields.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1112

  1. Christian Kuhn uploaded patch set 1 07/28/22, 13:17

  2. Oliver Klee voted on patch set 1 CR +1 07/28/22, 13:23

  3. core-ci voted on patch set 1 V +1 07/28/22, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29648

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 07/28/22, 14:28

  5. Georg Ringer commented on patch set 1 07/28/22, 17:23

  6. Georg Ringer voted on patch set 1 V -1 07/28/22, 17:24

  7. Stefan Bürk commented on patch set 1 07/29/22, 22:36

    Reply

    Yes and no. The linked patch does alot more, and is more global for all users using HIDE_FOR_NON_ADMINS, due the added TCA Migration. This patch however only "cleanups" the missconfiguration in the core. So if it is fine with you Georg, I would say we should take this patch to cleanup the core usages even in v11, and update your patch (which already needs a rebase because of merge conflicts) to provide the corresponding TCA migration message for instancens/extensions developers using this option along with exclude option. What do you think ?
  8. Georg Ringer commented on patch set 1 V 0 07/30/22, 05:26

    I am fine with both, if my patch would have been merged in the 1st place we wouldn't have the discussion anyway
  9. Christian Kuhn commented on patch set 1 07/30/22, 07:30

    You're right Georg, and I hadn't your patch on my radar. Let's follow Stefans strategy: Bring this one in v11 & v12, then let's rebase & finish your patch.
  10. Benni Mack voted on patch set 1 V +1 CR +1 07/31/22, 10:50

  11. Christian Kuhn voted on patch set 1 V +2 CR +2 07/31/22, 11:05

  12. Christian Kuhn merged patch set 2 07/31/22, 11:05