Review main Merged

75329[TASK] Update Bootstrap to 5.2.0

Andreas Kienast CR +2 V +2 Normal +51 −57 updated 07/31/22, 11:16

Commit message

Bootstrap is updated to 5.2.0. Due to a behavior change (perhaps a
regression), carousels need adoption if they shouldn't slide
automatically as the old approach results in indefinitely sliding:

```
- <div class="carousel slide" data-bs-interval="0" data-bs-ride="carousel">
+ <div class="carousel slide" data-bs-ride="false">
```

However, this is also documented at [1].

Executed commands:

    cd Build
    nvm use
    yarn add bootstrap@^5.2.0
    yarn add --dev @types/bootstrap@^5.2.0
    grunt build

[1] https://getbootstrap.com/docs/5.2/components/carousel/#options

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 27

Show 7 more files

Review log 1115

  1. Andreas Kienast uploaded patch set 1 07/29/22, 07:51

  2. core-ci voted on patch set 1 V -1 07/29/22, 08:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29682

  3. Andreas Kienast uploaded patch set 2 07/29/22, 09:03

  4. core-ci voted on patch set 2 V -1 07/29/22, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29684

  5. Andreas Kienast uploaded patch set 3 07/29/22, 10:11

  6. core-ci voted on patch set 3 V +1 07/29/22, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29688

  7. Andreas Kienast updated the commit message in patch set 4 07/29/22, 10:27

  8. Benni Mack voted on patch set 4 V +1 CR +1 07/29/22, 10:28

  9. core-ci voted on patch set 4 V +1 07/29/22, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29689

  10. Andreas Kienast commented on patch set 4 V -1 07/29/22, 10:35

    The control button for datetime pickers (and only those) are glitching, will check again.
  11. Andreas Kienast commented on patch set 4 V 0 07/29/22, 10:43

    The current implementation is broken on many levels, will do that in a separate patch.
  12. Markus Klein voted on patch set 4 CR +1 07/29/22, 10:51

  13. Stefan Bürk voted on patch set 4 V +1 CR +1 07/30/22, 18:16

  14. Andreas Kienast voted on patch set 4 V +2 CR +2 07/31/22, 11:16

  15. Andreas Kienast merged patch set 5 07/31/22, 11:16