75331[BUGFIX] Render proper markup for datetime picker buttons
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Markus Klein +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Markus Klein +1
- Riccardo De Contardi +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/global-event-handler.ts2+35 −17
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+3 −5
- typo3/sysext/backend/Resources/Public/JavaScript/global-event-handler.js+1 −1
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+3 −5
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditStartEndFields.html+4 −4
Review log 1620
-
Andreas Kienast uploaded patch set 1 07/29/22, 11:03
-
Andreas Kienast updated the commit message in patch set 2 07/29/22, 11:05
-
core-ci voted on patch set 1 V +1 07/29/22, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29693
-
core-ci voted on patch set 2 V +1 07/29/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29694
-
Markus Klein commented on patch set 2 07/29/22, 11:32
I'm not sure if this is actually a mix of responsibility. I wouldn't expect a focus action inside a function dealing with form submits -
Andreas Kienast commented on patch set 2 07/29/22, 11:38
Reply
You mean the naming of the callback function, right? Sure, I'll rename the function, I missed that. -
Andreas Kienast uploaded patch set 3 07/29/22, 11:45
-
core-ci voted on patch set 3 V +1 07/29/22, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29695
-
Markus Klein commented on patch set 3 07/31/22, 20:03
Reply
Done -
Anja Leichsenring voted on patch set 3 V +1 CR +1 08/02/22, 10:18
-
Oli Bartsch commented on patch set 3 08/04/22, 09:02
global-event-handler.ts:87We should also check for "parentForm" here. -
Andreas Kienast uploaded patch set 4 08/04/22, 10:42
-
core-ci voted on patch set 4 V +1 08/04/22, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29821
-
Riccardo De Contardi commented on patch set 4 V +1 08/04/22, 13:18
Tested with latest main -
Markus Klein voted on patch set 4 CR +1 08/04/22, 18:36
-
Markus Klein voted on patch set 4 V +1 08/04/22, 18:37
-
Andreas Kienast commented on patch set 4 08/06/22, 14:36
global-event-handler.ts:87ReplyDone -
Oli Bartsch voted on patch set 4 V +1 CR +1 08/06/22, 16:33
-
Andreas Kienast voted on patch set 4 V +2 CR +2 08/06/22, 16:45
-
Andreas Kienast merged patch set 5 08/06/22, 16:45