Review main Merged

75331[BUGFIX] Render proper markup for datetime picker buttons

Andreas Kienast CR +2 V +2 Normal +46 −32 updated 08/06/22, 16:45

Commit message

To make datetimer picker buttons focus the belonging textfield, the
buttons were rendered as `<label>` which is a very dirty hack, leading
to clitching buttons.

To solve this, the `@typo3/backend/global-event-handler` module is now
capable of focussing a specific element after clicking a trigger
element.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Markus Klein +1
    • Riccardo De Contardi +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1620

  1. Andreas Kienast uploaded patch set 1 07/29/22, 11:03

  2. Andreas Kienast updated the commit message in patch set 2 07/29/22, 11:05

  3. core-ci voted on patch set 1 V +1 07/29/22, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29693

  4. core-ci voted on patch set 2 V +1 07/29/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29694

  5. Markus Klein commented on patch set 2 07/29/22, 11:32

    I'm not sure if this is actually a mix of responsibility. I wouldn't expect a focus action inside a function dealing with form submits
  6. Andreas Kienast commented on patch set 2 07/29/22, 11:38

    Reply

    You mean the naming of the callback function, right? Sure, I'll rename the function, I missed that.
  7. Andreas Kienast uploaded patch set 3 07/29/22, 11:45

  8. core-ci voted on patch set 3 V +1 07/29/22, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29695

  9. Markus Klein commented on patch set 3 07/31/22, 20:03

    Reply

    Done
  10. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/02/22, 10:18

  11. Oli Bartsch commented on patch set 3 08/04/22, 09:02

    global-event-handler.ts:87

    We should also check for "parentForm" here.
  12. Andreas Kienast uploaded patch set 4 08/04/22, 10:42

  13. core-ci voted on patch set 4 V +1 08/04/22, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29821

  14. Riccardo De Contardi commented on patch set 4 V +1 08/04/22, 13:18

    Tested with latest main
  15. Markus Klein voted on patch set 4 CR +1 08/04/22, 18:36

  16. Markus Klein voted on patch set 4 V +1 08/04/22, 18:37

  17. Andreas Kienast commented on patch set 4 08/06/22, 14:36

    global-event-handler.ts:87 Reply

    Done
  18. Oli Bartsch voted on patch set 4 V +1 CR +1 08/06/22, 16:33

  19. Andreas Kienast voted on patch set 4 V +2 CR +2 08/06/22, 16:45

  20. Andreas Kienast merged patch set 5 08/06/22, 16:45