Review 11.5 Merged

75334[TASK] Address type issues in FileSearchQuery

Stefan Bürk CR +2 V +2 Easy +4 −15 updated 07/30/22, 18:20

Commit message

The $result property's doc type is causing issues
for PHPStan. Switching it to a typed property and
state resolves them.

Other types have been filled in as well as they're
private so safe.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk uploaded patch set 1 07/30/22, 18:11

  2. core-ci voted on patch set 1 V +1 07/30/22, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29719

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 07/30/22, 18:19

  4. Stefan Bürk merged patch set 2 07/30/22, 18:20