Review 11.5 Merged

75340[TASK] Update Bootstrap to 5.2.0

Andreas Kienast CR +2 V +2 Normal +52 −62 updated 07/31/22, 13:29

Commit message

Bootstrap is updated to 5.2.0. Due to a behavior change (perhaps a
regression), carousels need adoption if they shouldn't slide
automatically as the old approach results in indefinitely sliding:

```
- <div class="carousel slide" data-bs-interval="0" data-bs-ride="carousel">
+ <div class="carousel slide" data-bs-ride="false">
```

However, this is also documented at [1].

Executed commands:

    cd Build
    nvm use
    yarn add bootstrap@^5.2.0
    yarn add --dev @types/bootstrap@^5.2.0
    grunt build

[1] https://getbootstrap.com/docs/5.2/components/carousel/#options

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 26

Show 6 more files

Review log 610

  1. Andreas Kienast uploaded patch set 1 07/31/22, 11:25

  2. core-ci voted on patch set 1 V -1 07/31/22, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29753

  3. Andreas Kienast uploaded patch set 2 07/31/22, 12:01

  4. core-ci voted on patch set 2 V -1 07/31/22, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29755

  5. Andreas Kienast uploaded patch set 3 07/31/22, 12:51

  6. core-ci voted on patch set 3 V +1 07/31/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29758

  7. Andreas Kienast uploaded patch set 4 07/31/22, 13:02

  8. core-ci voted on patch set 4 V +1 07/31/22, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29759

  9. Andreas Kienast voted on patch set 4 V +2 CR +2 07/31/22, 13:29

  10. Andreas Kienast merged patch set 5 07/31/22, 13:29