Review main Abandoned

75341[BUGFIX] Adopt missing tooltip label changes

Andreas Kienast CR 0 V 0 Easy +6 −9 updated 02/03/23, 17:53

Commit message

With the update to Bootstrap 5.2.0, tooltip behavior changed
which is overseen in ajax-data-handler, especially when tooltip
labels are updated dynamically.

The method `setContent()` of the tooltip component is now used
to update it's value.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 3

Review log 58

  1. Andreas Kienast uploaded patch set 1 07/31/22, 12:34

  2. core-ci voted on patch set 1 V +1 07/31/22, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29756

  3. Andreas Kienast uploaded patch set 2 07/31/22, 12:41

  4. core-ci voted on patch set 2 V +1 07/31/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29757

  5. Christian Kuhn uploaded patch set 3 08/12/22, 21:16

  6. core-ci voted on patch set 3 V +1 08/12/22, 21:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30129

  7. Nikita Hovratov commented on patch set 3 V -1 08/12/22, 21:31

    I do get now this error message in console after clicking on hide and hovering over some hide toggle checkboxes: Uncaught DOMException: Element.querySelector: '0' is not a valid selector
  8. Christian Kuhn abandoned the change 02/03/23, 17:53