Review main Merged Breaking

75342[!!!][TASK] Remove Font Awesome icon provider

Andreas Kienast CR +2 V +2 Nightmare +63 −3797 updated 08/07/22, 08:42

Commit message

Any usage of FontAwesome has been removed with #97877 already. This
patch removes the integration of FontAwesome from the TYPO3 backend,
including the `FontAwesomeIconProvider`, the font files, and any CSS.

The polyfill extension is available via Composer via
```
composer require friendsoftypo3/fontawesome-provider
```
and in the TER soon.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 26

Show 6 more files

Review log 1824

  1. Andreas Kienast uploaded patch set 1 07/31/22, 14:16

  2. core-ci voted on patch set 1 V -1 07/31/22, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29760

  3. Simon Schaufelberger commented on patch set 1 08/01/22, 08:56

    what if I have an extension that uses the icon provider? will there be a new Typo3IconProvider as replacement?
  4. Simon Schaufelberger commented on patch set 1 08/01/22, 09:00

    Reply

    I have a content element extension that uses FontAwesome icons as CE type icon.
  5. Andreas Kienast commented on patch set 1 08/01/22, 09:28

    Reply

    Why should there be another IconProvider as a replacement if this patch apparently removes FontAwesome on purpose? Either use @typo3/icons (all of them are registered automatically) or wait for a polyfill extension that needs to be built before merging this patch.
  6. Andreas Kienast uploaded patch set 2 08/04/22, 08:57

  7. core-ci voted on patch set 2 V -1 08/04/22, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29818

  8. Andreas Kienast uploaded patch set 3 08/05/22, 20:54

  9. core-ci voted on patch set 3 V +1 08/05/22, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29859

  10. Andreas Kienast uploaded patch set 4 08/05/22, 21:21

  11. core-ci voted on patch set 4 V +1 08/05/22, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29864

  12. Andreas Kienast uploaded patch set 5 08/06/22, 10:08

  13. core-ci voted on patch set 5 V +1 08/06/22, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29889

  14. Benni Mack commented on patch set 5 CR -1 08/06/22, 14:11

    Ticket Number in Commit message missing
  15. Andreas Kienast updated the commit message in patch set 6 08/06/22, 14:11

  16. Andreas Kienast commented on patch set 6 08/06/22, 14:12

    Reply

    Thank you for this crucial hint. Highly appreciated!
  17. Benni Mack commented on patch set 6 08/06/22, 14:12

    OK. thanks.
  18. core-ci voted on patch set 6 V +1 08/06/22, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29896

  19. Benni Mack commented on patch set 6 08/06/22, 15:35

  20. Benni Mack commented on patch set 6 V +1 CR +1 08/06/22, 15:35

    Reply

    Done
  21. Markus Klein voted on patch set 6 CR +1 08/06/22, 19:05

  22. Stefan Bürk voted on patch set 6 V +1 CR +1 08/07/22, 08:39

  23. Andreas Kienast voted on patch set 6 V +2 CR +2 08/07/22, 08:42

  24. Andreas Kienast merged patch set 7 08/07/22, 08:42