75342[!!!][TASK] Remove Font Awesome icon provider
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Markus Klein +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 26
- Build/Sources/Sass/component/_elementbrowser.scss+0 −4
- Build/Sources/Sass/scaffold/_modulemenu.scss+0 −6
- Build/Sources/Sass/typo3/_element_tree.scss+1 −2
- Build/Sources/Sass/typo3/_icons.scss+0 −5
- Build/Sources/Sass/_minimal.scss+0 −2
- Build/Sources/TypeScript/backend/drag-uploader.ts+2 −1
- Build/Gruntfile.js+0 −6
- Build/package.json+0 −1
- Build/yarn.lock+0 −5
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+1 −1
- typo3/sysext/backend/Classes/LoginProvider/LoginProviderResolver.php+1 −1
- typo3/sysext/backend/Resources/Private/Layouts/Login.html+1 −8
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −2
- typo3/sysext/backend/Resources/Public/Fonts/FontAwesome/fontawesome-webfont.eotdeletedbinary
- typo3/sysext/backend/Resources/Public/Fonts/FontAwesome/fontawesome-webfont.svgdeleted+0 −2671
- typo3/sysext/backend/Resources/Public/Fonts/FontAwesome/fontawesome-webfont.ttfdeletedbinary
- typo3/sysext/backend/Resources/Public/Fonts/FontAwesome/fontawesome-webfont.woffdeletedbinary
- typo3/sysext/backend/Resources/Public/Fonts/FontAwesome/fontawesome-webfont.woff2deletedbinary
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+1 −1
- typo3/sysext/core/Classes/Imaging/IconProvider/FontawesomeIconProvider.phpdeleted+0 −969
Show 6 more files
- typo3/sysext/core/Classes/ServiceProvider.php+0 −9
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98089-RemovedFontAwesome.rstnew+45 −0
- typo3/sysext/core/Tests/Functional/Imaging/IconFactoryTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/FontawesomeIconProviderTest.phpdeleted+0 −94
- typo3/sysext/form/Resources/Public/Css/form.css+1 −1
- composer.lock+5 −5
Review log 1824
-
Andreas Kienast uploaded patch set 1 07/31/22, 14:16
-
core-ci voted on patch set 1 V -1 07/31/22, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29760
-
Simon Schaufelberger commented on patch set 1 08/01/22, 08:56
what if I have an extension that uses the icon provider? will there be a new Typo3IconProvider as replacement? -
Simon Schaufelberger commented on patch set 1 08/01/22, 09:00
Reply
I have a content element extension that uses FontAwesome icons as CE type icon. -
Andreas Kienast commented on patch set 1 08/01/22, 09:28
Reply
Why should there be another IconProvider as a replacement if this patch apparently removes FontAwesome on purpose? Either use @typo3/icons (all of them are registered automatically) or wait for a polyfill extension that needs to be built before merging this patch. -
Andreas Kienast uploaded patch set 2 08/04/22, 08:57
-
core-ci voted on patch set 2 V -1 08/04/22, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29818
-
Andreas Kienast uploaded patch set 3 08/05/22, 20:54
-
core-ci voted on patch set 3 V +1 08/05/22, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29859
-
Andreas Kienast uploaded patch set 4 08/05/22, 21:21
-
core-ci voted on patch set 4 V +1 08/05/22, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29864
-
Andreas Kienast uploaded patch set 5 08/06/22, 10:08
-
core-ci voted on patch set 5 V +1 08/06/22, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29889
-
Benni Mack commented on patch set 5 CR -1 08/06/22, 14:11
Ticket Number in Commit message missing -
Andreas Kienast updated the commit message in patch set 6 08/06/22, 14:11
-
Andreas Kienast commented on patch set 6 08/06/22, 14:12
Reply
Thank you for this crucial hint. Highly appreciated! -
Benni Mack commented on patch set 6 08/06/22, 14:12
OK. thanks. -
core-ci voted on patch set 6 V +1 08/06/22, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29896
-
Benni Mack commented on patch set 6 08/06/22, 15:35
Reply
I think this is now solved https://packagist.org/packages/friendsoftypo3/fontawesome-provider -
Benni Mack commented on patch set 6 V +1 CR +1 08/06/22, 15:35
Reply
Done -
Markus Klein voted on patch set 6 CR +1 08/06/22, 19:05
-
Stefan Bürk voted on patch set 6 V +1 CR +1 08/07/22, 08:39
-
Andreas Kienast voted on patch set 6 V +2 CR +2 08/07/22, 08:42
-
Andreas Kienast merged patch set 7 08/07/22, 08:42