Review main Merged

75344[BUGFIX] Replace legacy bootstrap classes supported by FontAwesome

Andreas Kienast CR +2 V +2 Normal +68 −68 updated 08/10/22, 07:51

Commit message

FontAwesome provides CSS classes that align with the old Bootstrap v3
classes, which will cause troubles with the removal of FontAwesome.
As another preparation task, those classes are be replaced with the
according Bootstrap classes.

Classes replaced:

* pull-left -> float-start
* pull-right -> float-end
* sr-only -> visually-hidden

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Georg Ringer +1
    • Stefan Kapitza-Graetz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Stefan Kapitza-Graetz +1
    • core-ci +1 CI

Issues 2

Files 45

Show 25 more files

Review log 1317

  1. Andreas Kienast uploaded patch set 1 08/02/22, 09:28

  2. Benni Mack commented on patch set 1 08/02/22, 09:29

    Something for v11 as well?
  3. core-ci voted on patch set 1 V -1 08/02/22, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29777

  4. Andreas Kienast commented on patch set 1 08/02/22, 09:44

    Reply

    Yep, that makes sense
  5. Nikita Hovratov commented on patch set 1 08/02/22, 15:22

    This is also fixed by that: https://forge.typo3.org/issues/94531
  6. Andreas Kienast uploaded patch set 2 08/03/22, 05:53

  7. core-ci voted on patch set 2 V -1 08/03/22, 06:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29790

  8. core-ci commented on patch set 2 08/03/22, 06:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29790

  9. core-ci voted on patch set 2 V +1 08/03/22, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29790

  10. Oli Bartsch voted on patch set 2 V +1 CR +1 08/04/22, 08:57

  11. Georg Ringer voted on patch set 2 CR +1 08/04/22, 12:27

  12. Riccardo De Contardi commented on patch set 2 08/04/22, 17:56

    am I wrong or there is an occurrence of 'sr-only' also in /Build/Sources/Sass/Scaffold/_modulemenu.scss (line 91)?
  13. Andreas Kienast commented on patch set 2 08/04/22, 18:07

    Reply

    That's correct and find for now. The usage within CSS will be removed altogether with FontAwesome itself.
  14. Stefan Kapitza-Graetz commented on patch set 2 V +1 CR +1 08/05/22, 19:48

    tested in dev-master and looks fine
  15. Andreas Kienast voted on patch set 2 V +2 CR +2 08/05/22, 19:54

  16. Andreas Kienast merged patch set 3 08/05/22, 19:54

  17. Matthäus Gundlach voted on patch set 2 CR +1 08/05/22, 19:58