75344[BUGFIX] Replace legacy bootstrap classes supported by FontAwesome
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Georg Ringer +1
- Stefan Kapitza-Graetz +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Stefan Kapitza-Graetz +1
- core-ci +1 CI
Issues 2
Files 45
- Build/Sources/TypeScript/backend/toolbar/live-search.ts+1 −1
- Build/Sources/TypeScript/backend/image-manipulation.ts+1 −1
- Build/Sources/TypeScript/backend/login-refresh.ts+2 −2
- Build/Sources/TypeScript/backend/modal.ts+1 −1
- Build/Sources/TypeScript/backend/multi-step-wizard.ts+1 −1
- Build/Sources/TypeScript/backend/notification.ts+1 −1
- typo3/sysext/backend/Classes/Form/Element/MfaInfoElement.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/SplitButton.php+1 −1
- typo3/sysext/backend/Resources/Private/Layouts/Login.html+1 −1
- typo3/sysext/backend/Resources/Private/Partials/Login/LoginNews.html+4 −4
- typo3/sysext/backend/Resources/Private/Templates/Form/ImageManipulationWizard.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/Login/ForgetPasswordForm.html+2 −2
- typo3/sysext/backend/Resources/Private/Templates/Login/ResetPasswordForm.html+2 −2
- typo3/sysext/backend/Resources/Private/Templates/Login/UserPassLoginForm.html+2 −2
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/UserToolbarItemDropDown.html+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/live-search.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/login-refresh.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/multi-step-wizard.js+1 −1
Show 25 more files
- typo3/sysext/backend/Resources/Public/JavaScript/notification.js+1 −1
- typo3/sysext/backend/Tests/Functional/Form/MfaInfoElementTest.php+2 −2
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+2 −2
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/CompareGroups.html+2 −2
- typo3/sysext/dashboard/Resources/Private/Layouts/Module.html+3 −3
- typo3/sysext/dashboard/Resources/Private/Templates/Dashboard/Main.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/TextEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/InsertPages.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/_ElementToolbar.html+1 −1
- typo3/sysext/form/Resources/Private/Templates/Backend/FormEditor/Index.html+1 −1
- typo3/sysext/install/Resources/Private/Partials/Upgrade/UpgradeDocs/PanelItem.html+4 −4
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseConnect.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseData.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseSelect.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDefaultConfiguration.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Layout/MainLayout.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Login/ShowLogin.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Upgrade/ExtensionScanner.html+4 −4
- typo3/sysext/install/Resources/Private/Templates/Upgrade/UpgradeDocsGetContent.html+1 −1
- typo3/sysext/opendocs/Resources/Private/Templates/ToolbarItems/DropDown.html+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+4 −4
- typo3/sysext/recordlist/Resources/Private/Layouts/LinkBrowser.html+1 −1
- typo3/sysext/recordlist/Resources/Private/Templates/ListNavigation.html+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+2 −2
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −1
Review log 1317
-
Andreas Kienast uploaded patch set 1 08/02/22, 09:28
-
Benni Mack commented on patch set 1 08/02/22, 09:29
Something for v11 as well? -
core-ci voted on patch set 1 V -1 08/02/22, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29777
-
Andreas Kienast commented on patch set 1 08/02/22, 09:44
Reply
Yep, that makes sense -
Nikita Hovratov commented on patch set 1 08/02/22, 15:22
This is also fixed by that: https://forge.typo3.org/issues/94531 -
Andreas Kienast uploaded patch set 2 08/03/22, 05:53
-
core-ci voted on patch set 2 V -1 08/03/22, 06:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29790
-
core-ci commented on patch set 2 08/03/22, 06:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29790
-
core-ci voted on patch set 2 V +1 08/03/22, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29790
-
Oli Bartsch voted on patch set 2 V +1 CR +1 08/04/22, 08:57
-
Georg Ringer voted on patch set 2 CR +1 08/04/22, 12:27
-
Riccardo De Contardi commented on patch set 2 08/04/22, 17:56
am I wrong or there is an occurrence of 'sr-only' also in /Build/Sources/Sass/Scaffold/_modulemenu.scss (line 91)? -
Andreas Kienast commented on patch set 2 08/04/22, 18:07
Reply
That's correct and find for now. The usage within CSS will be removed altogether with FontAwesome itself. -
Stefan Kapitza-Graetz commented on patch set 2 V +1 CR +1 08/05/22, 19:48
tested in dev-master and looks fine -
Andreas Kienast voted on patch set 2 V +2 CR +2 08/05/22, 19:54
-
Andreas Kienast merged patch set 3 08/05/22, 19:54
-
Matthäus Gundlach voted on patch set 2 CR +1 08/05/22, 19:58