Review main Merged

75347[BUGFIX] Set default value for correct sys_filemounts field

Oli Bartsch CR +2 V +2 Easy +3 −5 updated 08/04/22, 08:05

Commit message

Creating a sys_filemounts record via the context menu sets
the corresponding folders' combined identifier as default value
for the new record. With #97922, the previously used separate
fields "base" and "path" were replaced by the new "identifier"
field. Therefore the default value is now correctly set for this
new field.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Chris Müller +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Chris Müller +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Oli Bartsch uploaded patch set 1 08/03/22, 07:08

  2. core-ci voted on patch set 1 V -1 08/03/22, 07:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29791

  3. core-ci voted on patch set 1 V +1 08/03/22, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29791

  4. Chris Müller voted on patch set 1 V +1 CR +1 08/03/22, 17:51

  5. Andreas Kienast commented on patch set 1 CR -1 08/04/22, 08:03

    on it
  6. Andreas Kienast voted on patch set 1 V +1 CR +1 08/04/22, 08:05

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 08/04/22, 08:05

  8. Oli Bartsch merged patch set 2 08/04/22, 08:05