75351[BUGFIX] Use nullabe return type for method returning null
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Thomas Anders +1
- Matthäus Gundlach +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Thomas Anders +1
- Matthäus Gundlach +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1620
-
Georg Ringer uploaded patch set 1 08/05/22, 09:02
-
Georg Ringer commented on patch set 1 08/05/22, 09:02
This change is ready for review. -
core-ci voted on patch set 1 V +1 08/05/22, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29828
-
Timo Webler voted on patch set 1 CR +1 08/05/22, 09:33
-
Timo Webler voted on patch set 1 V +1 08/05/22, 10:06
-
Stefan Bürk updated the commit message in patch set 2 08/05/22, 20:19
-
Stefan Bürk updated the commit message in patch set 3 08/05/22, 20:21
-
Stefan Bürk updated the commit message in patch set 4 08/05/22, 20:23
-
Stefan Bürk voted on patch set 4 V +1 CR +1 08/05/22, 20:23
-
core-ci voted on patch set 3 V +1 08/05/22, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29853
-
core-ci voted on patch set 4 V +1 08/05/22, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29854
-
core-ci voted on patch set 2 V +1 08/05/22, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29852
-
Simon Schaufelberger voted on patch set 4 V +1 CR +1 08/05/22, 20:40
-
Simon Schaufelberger commented on patch set 4 08/05/22, 20:41
I'm surprised that phpstan didn't see that error -
Thomas Anders commented on patch set 4 V +1 CR +1 08/07/22, 16:37
Looks good to me -
Thomas Anders commented on patch set 4 08/07/22, 16:37
Looks good to me -
Matthäus Gundlach voted on patch set 4 CR +1 08/07/22, 16:52
-
Matthäus Gundlach voted on patch set 4 V +1 08/07/22, 17:10
-
Stefan Bürk commented on patch set 4 V +2 CR +2 08/07/22, 17:16
Reply
PHPStan would have detected this if we would have been on a higher level. This check is a rule of level 7 as it seems. Core is however on 5 currently. https://phpstan.org/r/bbab8b55-44c9-49b8-b15c-159a338b68f2 -
Stefan Bürk merged patch set 5 08/07/22, 17:16