Review 11.5 Merged

75363[BUGFIX] Use ClassSchema to properly detect DomainObject properties

Benni Mack CR +2 V +2 Normal +134 −80 updated 08/08/22, 17:21

Commit message

To gather information about properties of domain objects, extbase
used method DomainObjectInterface::_getProperties() which internally
used get_object_vars() which does not return uninitialized properties.

This leads to the inability to use such uninitialized properties
in models. Hence, those properties are not reconstituted at all
when converting an object instance from a database row, eventually
leading to fatal errors.

To mitigate this issue, extbase does now use the existing information
about classes gathered via ClassSchema which gathers information via
reflection (anyway).

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 34

  1. Benni Mack commented on patch set 1 08/08/22, 12:48

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/08/22, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29954

  3. Benni Mack voted on patch set 1 V +2 CR +2 08/08/22, 17:21

  4. Benni Mack merged patch set 2 08/08/22, 17:21