Review 10.4 Merged

75369[BUGFIX] Allow non-valid absolute paths for createVersionNumberFileName

Benni Mack CR +2 V +2 Easy +10 −2 updated 08/11/22, 15:13

Commit message

With the fix of using versioned numbered filenames for the
TYPO3 Backend, a use-case "absolutely referenced, but
relative to public path file" did break for Frontend
inclusions of CSS or JS files.

This is now overcome by only using the original bugfix in the TYPO3
Backend.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 69

  1. Benni Mack commented on patch set 1 08/10/22, 15:05

    Cherry Picked from branch 11.5. The following files contain Git conflicts: * typo3/sysext/core/Classes/Utility/GeneralUtility.php
  2. Benni Mack commented on patch set 2 08/10/22, 15:06

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 08/10/22, 15:06

  4. core-ci voted on patch set 1 V -1 08/10/22, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30019

  5. core-ci voted on patch set 2 V -1 08/10/22, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30020

  6. Benni Mack commented on patch set 3 08/10/22, 15:40

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V +1 08/10/22, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30023

  8. Benni Mack voted on patch set 3 V +2 CR +2 08/11/22, 15:13

  9. Benni Mack merged patch set 4 08/11/22, 15:13