Review main Merged

75378[TASK] Use preconfigured UTF-8 System in first installation

Annett Jähnichen CR +2 V +2 Easy +1 −0 updated 08/12/22, 20:37

Commit message

Back in the old and dark days, some filesystems did not know
about "special" chars. TYPO3 has the TYPO3_CONF_VARS toggle
['SYS']['UTF8filesystem'] to declare if filesytems are
UTF-8 aware.

This toggle is 'false' by default since ever. It triggers
functionality to rename any file that contains characters
like umlauts, or maybe entirely consist of "special" chars
only (japanese) to something "safe".

This is a usability issue since information is lost and
language-specific characters are destroyed.

Nowadays, any serious filesystem of course supports UTF-8.

There are no issues related to UTF8filesystem=true for
years.

The patch now sets UTF8filesystem=true for new installations
to see if anything still pops up. If that works out, we'll
continue with further patches in v13 to further phase out
the option entirely.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Annett Jähnichen uploaded patch set 1 08/05/22, 21:21

  2. core-ci voted on patch set 1 V +1 08/05/22, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29863

  3. Simon Schaufelberger commented on patch set 1 08/05/22, 22:09

    What are "UTF-8 issues"? Can this become a problem on some systems?
  4. Benni Mack commented on patch set 1 CR -1 08/06/22, 14:09

    I am against this change.
  5. Christian Kuhn uploaded patch set 2 08/07/22, 15:03

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 08/07/22, 15:04

  7. Christian Kuhn updated the commit message in patch set 3 08/07/22, 15:04

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 08/07/22, 15:05

  9. Simon Schaufelberger voted on patch set 3 V +1 CR +1 08/07/22, 15:07

  10. core-ci voted on patch set 2 V +1 08/07/22, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29921

  11. core-ci voted on patch set 3 V +1 08/07/22, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29922

  12. Stefan Bürk voted on patch set 3 V +2 CR +2 08/12/22, 20:37

  13. Stefan Bürk merged patch set 4 08/12/22, 20:37