75381[TASK] Refactor and simplify array access
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 50
- Build/phpstan/phpstan-baseline.neon+5 −15
- typo3/sysext/adminpanel/Classes/Modules/Debug/QueryInformation.php+3 −5
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+6 −8
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php1+8 −7
- typo3/sysext/backend/Classes/Controller/Page/LocalizationController.php+10 −14
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php1+6 −7
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowInitializeNew.php+3 −5
- typo3/sysext/backend/Classes/Form/FormDataProvider/EvaluateDisplayConditions.php+39 −41
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php+5 −8
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaTypesShowitem.php+1 −1
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+1 −1
- typo3/sysext/backend/Classes/History/RecordHistory.php1+2 −4
- typo3/sysext/backend/Classes/RecordList/ElementBrowserRecordList.php1+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php1+3 −5
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+13 −15
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+2 −2
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+19 −23
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+1 −1
Show 30 more files
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php1+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+15 −17
- typo3/sysext/core/Classes/Hooks/TcaItemsProcessorFunctions.php+1 −1
- typo3/sysext/core/Classes/Resource/Rendering/VideoTagRenderer.php+3 −3
- typo3/sysext/core/Classes/Resource/Security/FileMetadataPermissionsAspect.php+43 −47
- typo3/sysext/core/Classes/Service/MarkerBasedTemplateService.php1+5 −7
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+34 −40
- typo3/sysext/extbase/Classes/Mvc/ExtbaseRequestParameters.php1+4 −6
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php1+2 −4
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+1 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php+7 −13
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractFormElement.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/Section.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+1 −1
- typo3/sysext/form/Classes/Service/TranslationService.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+1 −1
- typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php+1 −1
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+7 −11
- typo3/sysext/impexp/Classes/ImportExport.php+1 −1
- typo3/sysext/indexed_search/Classes/FileContentParser.php+5 −7
- typo3/sysext/install/Classes/Controller/SettingsController.php+6 −0
- typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php1+1 −4
- typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php+9 −13
- typo3/sysext/lowlevel/Classes/Command/OrphanRecordsCommand.php+6 −10
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+54 −65
- typo3/sysext/lowlevel/Classes/Integrity/DatabaseIntegrityCheck.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php1+1 −1
- typo3/sysext/seo/Classes/XmlSitemap/RecordsXmlSitemapDataProvider.php+2 −4
- typo3/sysext/workspaces/Classes/Command/WorkspaceVersionRecordsCommand.php+10 −12
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+1 −1
Review log 2436
Show 611 earlier messages
-
Tizian Schmidlin uploaded patch set 1 08/05/22, 22:19
-
core-ci voted on patch set 1 V -1 08/05/22, 22:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29871
-
Tizian Schmidlin uploaded patch set 2 08/06/22, 11:23
-
Tizian Schmidlin uploaded patch set 3 08/06/22, 11:25
-
core-ci voted on patch set 2 V -1 08/06/22, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29891
-
core-ci voted on patch set 3 V -1 08/06/22, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29892
-
Tizian Schmidlin uploaded patch set 4 08/06/22, 11:46
-
core-ci voted on patch set 4 V -1 08/06/22, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29893
-
Tizian Schmidlin uploaded patch set 5 08/08/22, 07:02
-
core-ci voted on patch set 5 V -1 08/08/22, 07:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29934
-
Tizian Schmidlin commented on patch set 5 08/08/22, 08:27
SelectSingleElement.php:185UnresolvedWe already ensured above that `$selectItemGroup['item']` is available, therefore no need for further check.RecordHistory.php:239Unresolved`$this->getHistoryDataForRecord` always returns an array, so checking it is usless. Also an empty array still works in foreach.ElementBrowserRecordList.php:82UnresolvedChange for consistency.BackendUtility.php:152UnresolvedThis is a valid replacement, since getRecord returns an `array|null`.DefaultTcaSchema.php:463Unresolved@benni Any thoughts?MarkerBasedTemplateService.php:501UnresolvedWe don't need to test for `array` here, since the method signature enforces it already.TemplateService.php:1014UnresolvedIt is very unlikely, that $this->setup is not either null or an array (even if it is empty, this is still valid).ExtbaseRequestParameters.php:206Unresolved`get_class_methods` always returns an array.Typo3DbQueryParser.php:617Unresolved`$columnMap->getRelationTableMatchFields()` always returns an array.RequestHandler.php:418UnresolvedThis either exists and is an array ("dot"-index) or does not exist.CleanFlexFormsCommand.php:171Unresolved`BackendUtility::selectVersionsOfRecord` will always return an array or null, therefore we can catch a null beforehand and set an empty arrayConfigurationStatus.php:147Unresolved`$this->getConfiguredMemcachedServers()` always returns an array
-
Benni Mack updated the commit message in patch set 6 08/08/22, 08:28
-
core-ci voted on patch set 6 V -1 08/08/22, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29939
-
Tizian Schmidlin commented on patch set 6 08/25/22, 08:44
Unresolved
> Patch Set 6: Verified-1 > > Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29939 Some MariaDB Tests seem to fail, but I have no idea why. Is there a good way to find out, what causes the issue when using MariaDB and PHP 8.1 or a good way to visualize the error? -
Oliver Klee commented on patch set 6 08/25/22, 09:29
The lines in the commit message are a bit too long (so that they wrap in Gerrit). Could you please shorten them? -
Tizian Schmidlin uploaded patch set 7 08/25/22, 11:27
-
core-ci voted on patch set 7 V -1 08/25/22, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30443
-
Oliver Klee commented on patch set 7 08/25/22, 11:55
Reply
Done -
Oliver Klee wrote 08/25/22, 11:55
Removed cc Oliver Klee. -
Simon Schaufelberger commented on patch set 7 09/24/22, 23:06
Unresolved
why is this breaking if there is no breaking.rst? -
Benni Mack uploaded patch set 8 10/06/22, 08:16
-
core-ci voted on patch set 8 V -1 10/06/22, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32054
-
Benni Mack uploaded patch set 9 11/14/22, 09:43
-
core-ci voted on patch set 9 V -1 11/14/22, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33692
-
Benni Mack commented on patch set 9 07/04/23, 13:16
ping. either we split this one up into smaller chunks, or we abandon it completely (or we just fix the FlexFormUtility in this patch?) -
Stefan Bürk commented on patch set 9 09/27/23, 15:16
Reply
@Tizian What should we do with this patch ? Would you trim it down / split it. I would say, we should at least narrow it down to the exact need for the FlexFormUtility. -
Benni Mack uploaded patch set 10
V -101/08/24, 11:23 -
core-ci voted on patch set 10 V -1 01/08/24, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51221
-
Benni Mack uploaded patch set 11
V -101/12/24, 14:08 -
core-ci voted on patch set 11 V -1 01/12/24, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51507
-
Benni Mack uploaded patch set 12
V -101/12/24, 14:38 -
Benni Mack commented on patch set 12 01/12/24, 14:42
Reply
The only error that now occurs in the CI is probably the actual cause. I propose to keep the current patch as cleanup and fix the FlexForm Change then -
core-ci voted on patch set 12 V -1 01/12/24, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51511
-
Benni Mack commented on patch set 12 06/19/24, 21:02
anyone going to continue on this? I suggest to split this up into smaller chunks (we already fixed a lot of those), and then abandon this change, if no one wants to pick this change up. -
Christian Kuhn commented on patch set 12 07/09/24, 15:54
Hey. I think its fair to abandon here for now: This patch has lots of merge conflicts, and it seems nobody is really picking it up again. In case this should be picked up again, we may simply start over with fresh patches and issues. -
Christian Kuhn abandoned the change 07/09/24, 15:54
NewContentElementController.php:226Unresolved