Review main Merged

75383[TASK] Remove default script type "text/javascript" from <script> tags

Ionel-Alex Caizer CR +2 V +2 Easy +5 −5 updated 08/12/22, 20:57

Commit message

Omit obsolete type=text/javascript in PageRenderer
See: https://html.spec.whatwg.org/multipage/scripting.html#the-script-element

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1519

  1. Ionel-Alex Caizer uploaded patch set 1 08/05/22, 22:33

  2. core-ci voted on patch set 1 V +1 08/05/22, 22:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29875

  3. Simon Schaufelberger updated the commit message in patch set 2 08/05/22, 22:58

  4. Simon Schaufelberger commented on patch set 2 V +1 CR +1 08/05/22, 22:58

    I consider this a TASK because it's not really a bug.
  5. core-ci voted on patch set 2 V +1 08/05/22, 23:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29876

  6. Ionel-Alex Caizer updated the commit message in patch set 3 08/06/22, 15:21

  7. core-ci voted on patch set 3 V +1 08/06/22, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29905

  8. Christian Kuhn commented on patch set 3 08/07/22, 14:32

    +1 in general, just unsure about v11, since this potentially affects FE output. opinions?
  9. Benni Mack commented on patch set 3 08/07/22, 14:36

    Reply

    I recommend v12 only
  10. Simon Schaufelberger wrote 08/07/22, 14:48

    Removed reviewer Simon Schaufelberger.
  11. Christian Kuhn uploaded patch set 4 08/12/22, 20:38

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 08/12/22, 20:39

  13. Nikita Hovratov voted on patch set 4 V +1 CR +1 08/12/22, 20:40

  14. Stefan Bürk voted on patch set 4 V +1 CR +1 08/12/22, 20:40

  15. Stefan Bürk voted on patch set 4 V +2 CR +2 08/12/22, 20:40

  16. Stefan Bürk voted on patch set 4 V +1 CR +1 08/12/22, 20:40

  17. core-ci voted on patch set 4 V +1 08/12/22, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30125

  18. Christian Kuhn voted on patch set 4 V +2 CR +2 08/12/22, 20:57

  19. Christian Kuhn merged patch set 5 08/12/22, 20:57