Review main Merged

75385[BUGFIX] Fix relationship import with sql strict_mode

Rémy DANIEL CR +2 V +2 Easy +19 −2 updated 08/07/22, 15:28

Commit message

When sql strict mode is enabled on the database server,
if a value has a wrong data type for the database column,
the INSERT or UPDATE query will fail.
This happened during a t3d import: relationships are lost.

This patch fixes the issue by using the TCA default value for the field.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1116

  1. Rémy DANIEL uploaded patch set 1 08/05/22, 23:32

  2. core-ci voted on patch set 1 V +1 08/05/22, 23:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29879

  3. Simon Schaufelberger uploaded patch set 2 08/06/22, 00:22

  4. Simon Schaufelberger voted on patch set 2 CR +1 08/06/22, 00:23

  5. core-ci voted on patch set 2 V +1 08/06/22, 00:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29881

  6. Simon Schaufelberger updated the commit message in patch set 3 08/06/22, 01:24

  7. core-ci voted on patch set 3 V +1 08/06/22, 01:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29885

  8. Andreas Kienast voted on patch set 3 CR +1 08/06/22, 14:31

  9. Christian Kuhn commented on patch set 3 08/07/22, 14:40

    i hope it's ok to restrict to main & 11 since v10 is hard to port since we had various bigger changes in v11 in this area.
  10. Christian Kuhn updated the commit message in patch set 4 08/07/22, 14:41

  11. core-ci voted on patch set 4 V +1 08/07/22, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29920

  12. Nikita Hovratov uploaded patch set 5 08/07/22, 15:12

  13. core-ci voted on patch set 5 V +1 08/07/22, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29923

  14. Nikita Hovratov voted on patch set 5 V +1 CR +1 08/07/22, 15:27

  15. Christian Kuhn voted on patch set 5 V +2 CR +2 08/07/22, 15:28

  16. Christian Kuhn merged patch set 6 08/07/22, 15:28