Review main Merged

75387[TASK] Remove superfluous TYPO3_CONF_VARS | BE | fluidPageModule

Chris Müller CR +2 V +2 Easy +1 −2 updated 08/06/22, 14:15

Commit message

With https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186 the Fluid-based page view layout was introduced. However, a leftover setting from the development of this feature remains in the TYPO3_CONF_VARS setting:
BE|fluidPageModule. Instead, a feature flag was used to switch to the deprecated page view layout.

See also the comment in:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186/50/typo3/sysext/core/Configuration/DefaultConfiguration.php#1078

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Chris Müller uploaded patch set 1 08/06/22, 07:53

  2. core-ci voted on patch set 1 V +1 08/06/22, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29888

  3. Benni Mack voted on patch set 1 V +1 CR +1 08/06/22, 14:03

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 08/06/22, 14:15

  5. Andreas Kienast merged patch set 2 08/06/22, 14:15