Review main Merged

75388[BUGFIX] Add sd and hq YouTube preview image resolutions

Michael Hitzler CR +2 V +2 Easy +1 −1 updated 08/12/22, 20:30

Commit message

The YouTube helper tries to fetch from highest to
lowest image for possible previews.
The "sd" and "hq" versions were missing while checking
for an available image and got added.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Albrecht Köhnlein +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Albrecht Köhnlein +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1822

  1. Michael Hitzler uploaded patch set 1 08/06/22, 14:22

  2. Daniel Siepmann updated the commit message in patch set 2 08/06/22, 14:30

  3. Daniel Siepmann voted on patch set 2 CR +1 08/06/22, 14:31

  4. core-ci voted on patch set 1 V +1 08/06/22, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29899

  5. core-ci voted on patch set 2 V +1 08/06/22, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29900

  6. Albrecht Köhnlein commented on patch set 2 08/06/22, 15:38

    YouTubeHelper.php:51

    There seems to be at least one more format: https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.jpg Would it make sense to add this size to the list too?
  7. Simon Schaufelberger updated the commit message in patch set 3 08/07/22, 22:53

  8. core-ci voted on patch set 3 V +1 08/07/22, 23:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29930

  9. Michael Hitzler uploaded patch set 4 08/08/22, 09:29

  10. Simon Schaufelberger commented on patch set 4 V +1 CR +1 08/08/22, 09:36

    YouTubeHelper.php:51 Reply

    Done
  11. core-ci voted on patch set 4 V +1 08/08/22, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29944

  12. Simon Schaufelberger wrote 08/08/22, 09:38

    Removed Verified+1 by Simon Schaufelberger
  13. Simon Schaufelberger wrote 08/08/22, 09:38

    Removed Code-Review+1 by Simon Schaufelberger
  14. Simon Schaufelberger commented on patch set 4 CR -1 08/08/22, 09:38

    YouTubeHelper.php:51

    isn't the order wrong now? hq is higher than sd
  15. Michael Hitzler commented on patch set 4 08/08/22, 09:56

    YouTubeHelper.php:51 Reply

    Absolutely. Will add SD version as well.

    YouTubeHelper.php:51 Reply

    Naming seems missleading, but the order is right. sddefault.jpg (640x480 | 4:3) hqdefault.jpg (480x360 | 4:3)
  16. Simon Schaufelberger voted on patch set 4 V +1 CR +1 08/08/22, 10:50

  17. Albrecht Köhnlein voted on patch set 4 V +1 CR +1 08/08/22, 12:37

  18. Christian Kuhn voted on patch set 4 CR +1 08/12/22, 20:28

  19. Stefan Bürk voted on patch set 4 V +1 CR +1 08/12/22, 20:28

  20. Nikita Hovratov voted on patch set 4 V +1 CR +1 08/12/22, 20:29

  21. Nikita Hovratov voted on patch set 4 V +2 CR +2 08/12/22, 20:29

  22. Nikita Hovratov merged patch set 5 08/12/22, 20:30